Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If physbone/contacts are synced, dont set the access insts on remote #187

Closed
wants to merge 1 commit into from
Closed

If physbone/contacts are synced, dont set the access insts on remote #187

wants to merge 1 commit into from

Conversation

jellejurre
Copy link
Collaborator

No description provided.

@jellejurre
Copy link
Collaborator Author

Fixes #186

lyuma
lyuma approved these changes Sep 25, 2024
View reviewed changes
Copy link
Owner

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I might make it cache the reflection.

lyuma added a commit that referenced this pull request Sep 25, 2024
@lyuma @jellejurre
If physbone/contacts are synced, dont set the access insts on remote #…
462a998 
…187

Co-Authored-By: jellejurre <[email protected]>
@lyuma
Copy link
Owner

lyuma commented Sep 25, 2024

Committed 462a998. Thanks!
I saw we already had the synced variable which is initialized from networkSynced, so I simplified the reflection code to use that.

@lyuma lyuma closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuma lyuma lyuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jellejurre @lyuma