Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README: reflect abstract state view rule. #19

Merged
merged 1 commit into from
Aug 28, 2014
Merged

Update README: reflect abstract state view rule. #19

merged 1 commit into from
Aug 28, 2014

Conversation

cseeger
Copy link
Contributor

@cseeger cseeger commented Aug 28, 2014

Submitting this change in hopes it might prevent someone else going mad when their views templates don't load. (Especially those that might copy/paste...)

As per the rule on abstract state views: "Abstract states still need their own for their children to plug into. So if you are using an abstract state just to prepend a url, set resolves/data, or run an onEnter/Exit function, then you'll additionally need to set template: ''"

Submitting this change in hopes it might prevent someone else going mad when their views templates don't load. (Especially those that might copy/paste...)

As per the rule on abstract state views: "Abstract states still need their own <ui-view/> for their children to plug into. So if you are using an abstract state just to prepend a url, set resolves/data, or run an onEnter/Exit function, then you'll additionally need to set template: '<ui-view/>'"
@lynndylanhurley
Copy link
Owner

Thanks @cseeger!

lynndylanhurley added a commit that referenced this pull request Aug 28, 2014
Update README: reflect abstract state view rule.
@lynndylanhurley lynndylanhurley merged commit b2dcf19 into lynndylanhurley:master Aug 28, 2014
@cseeger cseeger deleted the patch-1 branch August 28, 2014 01:36
nbrustein pushed a commit to nbrustein/ng-token-auth that referenced this pull request May 27, 2015
guard against MissingAttributeError during common ActiveRecord operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants