-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(improved-omniauth): add support for sameWindow and inAppBrowser omniauth flows #188
Conversation
Cool which release will include this pull request. |
@elhachimi - it's slated for 0.0.28, but you're more than welcome to pull it down via bower by pointing directly to the branch. ie - |
17af3be
to
8d9b184
Compare
feat(improved-omniauth): add support for sameWindow and inAppBrowser omniauth flows
I used it, it works, but not persist the session in the ionic application. Can you help me to solve it? |
The log error
|
This provides a mechanism to select between
sameWindow
(new default),newWindow
(old default), orinAppBrowser
modes for OAuth. This should allow for improved OAuth flows for a variety of use-cases, as well as supporting Cordova / PhoneGap implementations.see also: lynndylanhurley/devise_token_auth#323 for devise_token_auth back-end implementation
Closes #90, #141