Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(improved-omniauth): add support for sameWindow and inAppBrowser omniauth flows #188

Merged
merged 1 commit into from
Aug 9, 2015

Conversation

booleanbetrayal
Copy link
Collaborator

This provides a mechanism to select between sameWindow (new default), newWindow (old default), or inAppBrowser modes for OAuth. This should allow for improved OAuth flows for a variety of use-cases, as well as supporting Cordova / PhoneGap implementations.

see also: lynndylanhurley/devise_token_auth#323 for devise_token_auth back-end implementation

Closes #90, #141

@elhachimi
Copy link

Cool which release will include this pull request.

@booleanbetrayal
Copy link
Collaborator Author

@elhachimi - it's slated for 0.0.28, but you're more than welcome to pull it down via bower by pointing directly to the branch. ie - "ng-token-auth": "git://github.com/lynndylanhurley/ng-token-auth.git#improved_omniauth_flow"

@booleanbetrayal booleanbetrayal force-pushed the improved_omniauth_flow branch from 17af3be to 8d9b184 Compare August 9, 2015 05:26
booleanbetrayal added a commit that referenced this pull request Aug 9, 2015
feat(improved-omniauth): add support for sameWindow and inAppBrowser omniauth flows
@booleanbetrayal booleanbetrayal merged commit 639b2dc into master Aug 9, 2015
@booleanbetrayal booleanbetrayal deleted the improved_omniauth_flow branch August 9, 2015 05:43
@dtelaroli
Copy link

I used it, it works, but not persist the session in the ionic application.
Maybe the cookies/session it's not setted corretly.

Can you help me to solve it?

@dtelaroli
Copy link

@booleanbetrayal

The log error

D/CordovaLog( 3506): file:///android_asset/www/lib/ionic/js/ionic.bundle.js: Line 19387 : TypeError: Cannot read property 'config' of undefined
D/CordovaLog( 3506):     at file:///android_asset/www/lib/ng-token-auth/dist/ng-token-auth.js:750:25
D/CordovaLog( 3506):     at Object.invoke (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:11994:17)
D/CordovaLog( 3506):     at response (file:///android_asset/www/lib/ng-token-auth/dist/ng-token-auth.js:748:23)
D/CordovaLog( 3506):     at processQueue (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20962:27)
D/CordovaLog( 3506):     at file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20978:27
D/CordovaLog( 3506):     at Scope.$eval (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22178:28)
D/CordovaLog( 3506):     at Scope.$digest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:21994:31)
D/CordovaLog( 3506):     at Scope.$apply (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22282:24)
D/CordovaLog( 3506):     at done (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17439:47)
D/CordovaLog( 3506):     at completeRequest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17629:7)
I/chromium( 3506): [INFO:CONSOLE(19387)] "TypeError: Cannot read property 'config' of undefined
I/chromium( 3506):     at file:///android_asset/www/lib/ng-token-auth/dist/ng-token-auth.js:750:25
I/chromium( 3506):     at Object.invoke (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:11994:17)
I/chromium( 3506):     at response (file:///android_asset/www/lib/ng-token-auth/dist/ng-token-auth.js:748:23)
I/chromium( 3506):     at processQueue (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20962:27)
I/chromium( 3506):     at file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20978:27
I/chromium( 3506):     at Scope.$eval (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22178:28)
I/chromium( 3506):     at Scope.$digest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:21994:31)
I/chromium( 3506):     at Scope.$apply (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22282:24)
I/chromium( 3506):     at done (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17439:47)
I/chromium( 3506):     at completeRequest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17629:7)", source: file:///android_asset/www/lib/ionic/js/ionic.bundle.js (19387)
D/CordovaLog( 3506): file:///android_asset/www/lib/ionic/js/ionic.bundle.js: Line 19387 : TypeError: Cannot call method 'join' of undefined
D/CordovaLog( 3506):     at file:///android_asset/www/js/interceptor.js:49:24
D/CordovaLog( 3506):     at Scope.$emit (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22423:33)
D/CordovaLog( 3506):     at self.error (file:///android_asset/www/js/controllers.js:195:14)
D/CordovaLog( 3506):     at processQueue (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20962:27)
D/CordovaLog( 3506):     at file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20978:27
D/CordovaLog( 3506):     at Scope.$eval (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22178:28)
D/CordovaLog( 3506):     at Scope.$digest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:21994:31)
D/CordovaLog( 3506):     at Scope.$apply (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22282:24)
D/CordovaLog( 3506):     at done (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17439:47)
D/CordovaLog( 3506):     at completeRequest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17629:7)
I/chromium( 3506): [INFO:CONSOLE(19387)] "TypeError: Cannot call method 'join' of undefined
I/chromium( 3506):     at file:///android_asset/www/js/interceptor.js:49:24
I/chromium( 3506):     at Scope.$emit (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22423:33)
I/chromium( 3506):     at self.error (file:///android_asset/www/js/controllers.js:195:14)
I/chromium( 3506):     at processQueue (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20962:27)
I/chromium( 3506):     at file:///android_asset/www/lib/ionic/js/ionic.bundle.js:20978:27
I/chromium( 3506):     at Scope.$eval (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22178:28)
I/chromium( 3506):     at Scope.$digest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:21994:31)
I/chromium( 3506):     at Scope.$apply (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:22282:24)
I/chromium( 3506):     at done (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17439:47)
I/chromium( 3506):     at completeRequest (file:///android_asset/www/lib/ionic/js/ionic.bundle.js:17629:7)", source: file:///android_asset/www/lib/ionic/js/ionic.bundle.js (19387)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants