fix(getSavedConfig): catch window.localStorage error #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| hasLocalStorage = !!$window.localStorage; | ||
| } catch (_error) { | ||
| error = _error; |
There was a problem hiding this comment.
Unused variable?
My suggestion is throw an error, console.warn also would be helpful.
There was a problem hiding this comment.
- Which unused variable do you mean? If you mean the 'error', it seemed like coffeescript required that. I'm no good at coffeescript, so I my have done it wrong.
- I def don't want to throw an error, since the whole point of this PR is to suppress the error.
- I don't think a console.warn is necessary. This library is supposed to support situations with no local storage, so it does not really require a warning, IMO.
|
Privacy mode, etc is a completely valid use case for a browser to be running in, so I don't think it should warn or anything. Just fall back accordingly. lgtm! |
booleanbetrayal
added a commit
that referenced
this pull request
Jun 16, 2015
fix(getSavedConfig): catch window.localStorage error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124