Check if recoverable is enabled in case allow_password_change is used #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zachfeldman
approved these changes
Oct 24, 2017
| @@ -28,4 +28,4 @@ bundle exec guard | |||
|
|
|||
| Guard will re-run each test suite when changes are made to its corresponding files. | |||
|
|
|||
| To run **just one test**: Flavio Castelli blogged about [how to execute a single unit test (or even a single test method)](https://webcache.googleusercontent.com/search?q=cache:lVNaE5lsPq0J:http://flavio.castelli.name/2010/05/28/rails_execute_single_test%2Bflavio.castelli.name/2010/05/28/rails_execute_single_test+!g&num=1&hl=en&strip=1&vwsrc=0) instead of running the complete unit test suite. | |||
| To run **just one test**: Flavio Castelli blogged about [how to execute a single unit test (or even a single test method)](https://flavio.castelli.me/2010/05/28/rails_execute_single_test/) instead of running the complete unit test suite. | |||
There was a problem hiding this comment.
You're right, this URL works...
|
Fine with me, waiting on one other approval to merge. |
lynndylanhurley
approved these changes
Nov 14, 2017
|
Good catch, thanks @MaicolBen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because projects that update the gem won't have the new field
allow_password_change, this prevents asking if the recoverable module is added. Also, I fixed the broken url of running a single test.