Document the confirm_success_url param for email registration #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nerfologist - thanks for taking the time to submit this PR. This change looks good, but it looks like there was another edit to this part of the readme that's causing a conflict. Can you please resolve the conflict? |
The `confirm_success_url` param is compulsory for registering a new user. Add mention in the corresponding API endpoint, beside `email`, `password` and `password_confirmation`.
nerfologist
force-pushed
the
document-confirm_success_url
branch
from
7eb6cd5 to
3ab8048
Compare
|
Hi, sorry for the delay, I finally found the time to look into it. The 8da9d50 commit by monkypuzzle now mentions the Thanks for this great library 👍 |
|
Looking good! Merging. Thanks @nerfologist ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
confirm_success_urlparam is required for email registration.Add mention in the corresponding API endpoint, beside
email,passwordandpassword_confirmation.Also, mention the possibility of specifying
default_confirm_success_urlin the initializer as an alternative.