Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error in controller method #430

Merged
merged 1 commit into from
Nov 28, 2015
Merged

Raise error in controller method #430

merged 1 commit into from
Nov 28, 2015

Conversation

ArneZsng
Copy link
Contributor

@ArneZsng ArneZsng commented Nov 2, 2015

Upgrading from v0.1.36 to v0.1.37.beta3 I noticed a change in passwords_controller.rb that broke at least my code with regards to #411

Though I agree that it should not show a json object in the browser, our logic and I guess some other projects as well might have overwritten render_edit_error to redirect to a single page app with a more specific error message.

I readded the render_edit_error method to easily override the behavior.

@booleanbetrayal
Copy link
Collaborator

Seems reasonable. Thanks @ArneZsng

booleanbetrayal added a commit that referenced this pull request Nov 28, 2015
Raise error in controller method
@booleanbetrayal booleanbetrayal merged commit 9668dc7 into lynndylanhurley:master Nov 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants