Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enable-standard-devise): allow configurable support of legacy Devise authentication #428

Merged
merged 1 commit into from
Oct 30, 2015

Conversation

booleanbetrayal
Copy link
Collaborator

Fixes #297

BREAKING CHANGE: Updates legacy Devise support to default to disabled rather than enabled.

This was causing all sorts of random issues for people who may not have needed the integration. This isolates it and denotes it as an experimental feature.

…vise authentication. update default to disabled.
@lynndylanhurley
Copy link
Owner

This looks great @booleanbetrayal!

@booleanbetrayal
Copy link
Collaborator Author

Yay!

booleanbetrayal added a commit that referenced this pull request Oct 30, 2015
…flag

feat(enable-standard-devise): allow configurable support of legacy Devise authentication
@booleanbetrayal booleanbetrayal merged commit 4630485 into master Oct 30, 2015
@booleanbetrayal booleanbetrayal deleted the standard_devise_support_flag branch October 30, 2015 21:02
@booleanbetrayal
Copy link
Collaborator Author

left out a revert on the bypass flag that was clearing the before_filter stuff -- see also: e0b4dff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants