Support for i18n in mailers views

[joeesteves]

With the english and spanish respective translations.

I've included the translation for mails subjects in the es.yml (this translation is usually included in devise translations 'cause ir seems natural to keep al mails views translations together but i'm not sure if is a good practice. Anyway, it's only 3 lines so i've can delete them if request.

bye

[joeesteves]

HI @booleanbetrayal @lynndylanhurley ,
Must I update my PR to be updated with master branch or normally you take care of that stuff. If i must, wich is the best practice to do so. Merge master into my fork master branch, resolve conflicts and push it again?

thanks,

[ValentinTrinque]

I would advise to do a rebase in order to make it cleaner.

[joeesteves]

Thanks @ValentinTrinque for your advice

I've done the rebase and its clean for merging know.

[booleanbetrayal]

@ponyesteves - This looks great, but I can't merge without complete translations. Could you provide Google Translate translations for all the other currently supported locales? Also, I see there's 3 commits, 1 a revert of another. Could you possible squash those in another rebase? Thanks!

[joeesteves]

@booleanbetrayal i've fixed the commits mess, now there is only one commit with all the changes (including the translations to all supported locales). Hopefully Google have done a good job on those translations, but i wouldn't risk my neck. So i think it should be checked by someone how actually knows those languages!

[booleanbetrayal]

thanks @ponyesteves !

[joeesteves]

You're welcome!
Glad to colaborate

El lun., 23 de nov. de 2015 a la(s) 1:46 p. m., Brent <
[email protected]> escribió:

Merged #427
#427.

—
Reply to this email directly or view it on GitHub
#427 (comment)
.