perf(update_auth_header): only lock the resource if we are rotating tokens #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okens and need to worry about contention
booleanbetrayal
added a commit
that referenced
this pull request
Jun 16, 2015
…ssary perf(update_auth_header): only lock the resource if we are rotating tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@resource.with_lockis causing a transaction which is what we want if we're rotating tokens and are dealing with any potential contention scenarios, but is entirely unnecessary if we're not saving anything and just grabbing the auth headers for the response. This removes an unnecessary transaction overhead from the DB. In real-world terms, we've seen these transactions take anywhere between 3 and 400ms, so there's a chance the savings are worth it for others.