Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ominauth): support json-formatted values in omniauth callback. #252

Conversation

nbrustein
Copy link
Contributor

Fixes #221

This is potentially a breaking change. For example, nil values used to be rendered as an empty string, but will now render as undefined.

We needed it because we have some values in there that are arrays.

@booleanbetrayal
Copy link
Collaborator

👍

booleanbetrayal added a commit that referenced this pull request Jun 16, 2015
…h-success

feat(ominauth): support json-formatted values in omniauth callback.
@booleanbetrayal booleanbetrayal merged commit d240002 into lynndylanhurley:master Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

omniauth_success.html.erb JSON bug
2 participants