URI fragment should appear at the end of URL #214
Conversation
|
This seems correct, but there was a comment to the effect that this was required in AngularJS for some reason. Any idea what that's all about @lynndylanhurley ? I can run it through some testing in a few days if it's hazy. |
|
@edymerchk - Can you go ahead and rebase against master, resolving conflicts please? Thanks! |
|
@edymerchk - reminder to rebase against master if you'd like credit for this PR! thanks! |
edymerchk
force-pushed
the
fix_fragment_and_params
branch
2 times, most recently
from
3ac7dc9 to
e7c6410
Compare
edymerchk
force-pushed
the
fix_fragment_and_params
branch
from
e7c6410 to
b60c7c3
Compare
|
@booleanbetrayal ready |
URI fragment should appear at the end of URL
|
Thanks @edymerchk ! |
|
+1 |
|
has this been merged into a version i can pull? i don't see it in 0.32.beta9. looks like i can bundle it with 0.32.beta10, but i don't see a tag for that one yet. i'm pulling it down with that one now. this URL issue doesn't break the confirmation process, but it prevents the ng-token-auth event auth:email-confirmation-success from firing in android because the URL params can't be parsed. |
|
I'm going to be stamping out a new stable build version shortly! |
Hi, thanks for this project !
as I mention in #213 the params in the query string for the
redirect_urlare not sent to the server due to the URI fragment.according to the RFC fragment should be at the end of the URL
more info: http://en.wikipedia.org/wiki/Fragment_identifier#Examples
not sure how Angular handle this, but I found: https://scotch.io/quick-tips/pretty-urls-in-angularjs-removing-the-hashtag