Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/Ruby 3.x and Rails 7.0 #1584

Conversation

jotolo
Copy link
Contributor

@jotolo jotolo commented Mar 20, 2023

Testing against different ruby and rails versions

Ruby:

  • 3.0
  • 3.1
  • 3.2

Rails:

  • 7.0

Description

  • Updating Gemfile for Rails 7.0
  • Adding Rails 7 Gemfile to test matrix
  • Adding exclusions for Rails 7 and Ruby versions
  • Update to checkout@v3 on Github Actions
  • Remove Travis configuration file
  • Fixing some typos

Sorry, something went wrong.

@jotolo jotolo force-pushed the feature/testing-agains-ruby-and-rails-versions branch from 2f1bae0 to 9cf3238 Compare March 20, 2023 11:07
@jotolo jotolo changed the title update/travis configuration file update/test configuration file Mar 20, 2023
@jotolo jotolo changed the title update/test configuration file update/tests configuration file Mar 20, 2023
@jotolo
Copy link
Contributor Author

jotolo commented Apr 3, 2023

Hi @MaicolBen ! Thanks for supporting this gem and the work you guys have done.
I opened this PR to update the test matrix and check against more ruby and Rails versions.
I noticed the master branch is broken at the moment. I was wondering if there is any plan to fix it or if there is anything I can help with. I am working on a migration of an app to ruby 3.2 and I would like all the gems we use to pass with this version of Ruby.
Also, showing it is compatible using this: https://railsbump.org/ would be a very good thing to have for all people using this gem.
Please, let me know how I can help and again, thanks for the work on this library and to all maintainers.

@MaicolBen
Copy link
Collaborator

@jotolo I fixed the master build, can you rebase?

@jotolo jotolo force-pushed the feature/testing-agains-ruby-and-rails-versions branch 3 times, most recently from ad5623c to a308648 Compare April 7, 2023 14:10
@jotolo jotolo marked this pull request as ready for review April 7, 2023 14:11
@jotolo
Copy link
Contributor Author

jotolo commented Apr 7, 2023

@MaicolBen Ready to go. I included the gemfile for Rails 7.1 but then realised is not available yet 😅 . I am not sure if the travis config file is being used. Let me know if it is not to remove it.
Thanks for checking 🤝

@MaicolBen
Copy link
Collaborator

Thanks, we aren't using travis anymore

@MaicolBen
Copy link
Collaborator

Weird, it fails on ruby 3 now 🤔

@jotolo jotolo force-pushed the feature/testing-agains-ruby-and-rails-versions branch from 571f627 to 1efefe3 Compare April 10, 2023 07:04
@jotolo jotolo force-pushed the feature/testing-agains-ruby-and-rails-versions branch from 5827051 to 530cf58 Compare April 10, 2023 07:56
@jotolo
Copy link
Contributor Author

jotolo commented Apr 10, 2023

@MaicolBen I managed to update some dependencies for Rails 7 using appraisal. Once those were up to date the tests passed.
Please, check and let me know. I have also removed the travis configuration file.

@jotolo jotolo changed the title update/tests configuration file update/Ruby 3.x and Rails 7.0 Apr 10, 2023
@MaicolBen MaicolBen mentioned this pull request Apr 14, 2023
@MaicolBen
Copy link
Collaborator

@jotolo Nice job 👏

@MaicolBen MaicolBen merged commit 7cd39f5 into lynndylanhurley:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants