-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: handling primary key type in generators #1195
feature: handling primary key type in generators #1195
Conversation
…Devise implementation)
…ator_with_primary_key_type
…have been provoked by the worker)
…and #21 this time)
So much trouble with Travis for such a little modification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, you don't have to push to rebuild travis, you can go to the travis dashboard for that.
Looks good, this won't work for rails 6 but it will keep working as always, so I'm ok with that. I will merge it in a couple of days if you don't change it
Thanks. I'm not gonna change it. I'll probably have more significant changes if I'm able to find the time to work on it, but I'll push a branch for each feature. btw, talking about Travis (which was turning me crazy since all the builds were passing on my forked repository), I'm probably missing something because I think we can't rerun an individual job, it probably requires being part of the project's team (that's the killing feature I was expecting and why I had to fake changes ;) |
sorry if you don't have the permission to rerun an individual job! |
Migration generator handles if the primary key is a UUID (based on Devise implementation)