Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: handling primary key type in generators #1195

Merged
merged 14 commits into from
Aug 5, 2018
Merged

feature: handling primary key type in generators #1195

merged 14 commits into from
Aug 5, 2018

Conversation

whois-marvin-42
Copy link
Contributor

Migration generator handles if the primary key is a UUID (based on Devise implementation)

@whois-marvin-42
Copy link
Contributor Author

So much trouble with Travis for such a little modification

Copy link
Collaborator

@MaicolBen MaicolBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, you don't have to push to rebuild travis, you can go to the travis dashboard for that.
Looks good, this won't work for rails 6 but it will keep working as always, so I'm ok with that. I will merge it in a couple of days if you don't change it

@whois-marvin-42
Copy link
Contributor Author

Thanks. I'm not gonna change it. I'll probably have more significant changes if I'm able to find the time to work on it, but I'll push a branch for each feature.

btw, talking about Travis (which was turning me crazy since all the builds were passing on my forked repository), I'm probably missing something because I think we can't rerun an individual job, it probably requires being part of the project's team (that's the killing feature I was expecting and why I had to fake changes ;)

@MaicolBen
Copy link
Collaborator

sorry if you don't have the permission to rerun an individual job!

@MaicolBen MaicolBen merged commit 29528bb into lynndylanhurley:master Aug 5, 2018
@whois-marvin-42 whois-marvin-42 deleted the feature/generator_with_primary_key_type branch August 8, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants