Code

Rebase rubocop branch#1156

Code

Closed

dks17 wants to merge 54 commits intolynndylanhurley:add_rubocoplynndylanhurley/devise_token_auth:add_rubocopfrom dks17:add_rubocop4dks17/devise_token_auth:add_rubocop4Copy head branch name to clipboard

+2,633-1,882

Commits

Commits on Mar 23, 2018

• Add rubocop

  Show description for 3afbd8b
  Evan-M

  committed
  3afbd8b

• Exclude some paths from rubocop analysis, at least for now.

  Evan-M

  committed
  ee29d0a

• Adding .erb extension to template.

  Show description for 4557afd
  Evan-M

  committed
  4557afd

Commits on Mar 24, 2018

• Fix Layout/EmptyLines

  Show description for 7419927
  Evan-M

  committed
  7419927

• Fix Style/StringLiterals

  Show description for c23c759
  Evan-M

  committed
  c23c759

• Move Style/FrozenStringLiteralComment from todos to main config.

  Show description for ab89dba
  Evan-M

  committed
  ab89dba

• Move Style/ClassAndModuleChildren from todos to main config.

  Show description for bfc0ede
  Evan-M

  committed
  bfc0ede

• Fix Style/HashSyntax

  Show description for deb1be2
  Evan-M

  committed
  deb1be2

• Fix Style/SymbolArray

  Show description for 022e832
  Evan-M

  committed
  022e832

• Update Style/Documentation todo to specify files with Cop violations.

  Evan-M

  committed
  88b9e47

• Update offense counts in rubocop todo list.

  Evan-M

  committed
  00672ad

Commits on Mar 25, 2018

• Fix Style/PreferredHashMethods

  dks17

  committed
  3edb53b

• Fix Style/NegatedIf

  dks17

  committed
  7e3dffc

• Fix Layout/SpaceInsideHashLiteralBraces

  dks17

  committed
  185245f

• Fix Layout/SpaceInsideStringInterpolation

  dks17

  committed
  7c0bd98

• Fix Layout/CommentIndentation

  dks17

  committed
  e055c89

• Fix Style/TrailingCommaInHashLiteral

  dks17

  committed
  1035908

Commits on Mar 26, 2018

• Update parser gem.

  Show description for 7418df4
  Evan-M

  committed
  7418df4

Commits on Mar 27, 2018

• Update rubocop todo list and exclusions.

  Evan-M

  committed
  2c4cd08

Commits on Mar 28, 2018

• Partially fix Metrics/LineLength.

  Show description for c470e2b
  Evan-M

  committed
  c470e2b

Commits on Mar 29, 2018

• Partially (mostly) fix Metrics/BlockLength.

  Show description for 1afb2b2
  Evan-M

  committed
  1afb2b2

• Fix Style/ExpandPathArguments

  Evan-M

  committed
  e4a4c7b

• Fix Layout/IndentHash

  Show description for 67cff72
  Evan-M

  committed
  67cff72

• Fix Layout/SpaceInsideBlockBraces

  Evan-M

  committed
  be62644

• Fix Layout/EmptyLinesAroundClassBody

  Evan-M

  committed
  98f6b03

• Fix Layout/SpaceAroundEqualsInParameterDefault

  Evan-M

  committed
  0250c27

• Fix Style/BracesAroundHashParameters

  Evan-M

  committed
  db7dcf0

Commits on Mar 30, 2018

• Fix Layout/AlignParameters

  Evan-M

  committed
  c3d093e

• Fix Style/WordArray

  Show description for 408d6c9
  Evan-M

  committed
  408d6c9

• Fix Style/BlockDelimiters

  Show description for 06ca1be
  Evan-M

  committed
  06ca1be

• Fix Style/IfUnlessModifier

  Evan-M

  committed
  4b30adb

• Fix Style/PercentLiteralDelimiters

  Evan-M

  committed
  6b55414

• Fix Style/MutableConstant

  Evan-M

  committed
  740c970

• Fix Style/AndOr

  Evan-M

  committed
  323a438

• Fix Style/RedundantSelf

  Evan-M

  committed
  cbb6def

• Fix Style/RaiseArgs

  Evan-M

  committed
  c6b2fda

• Fix Style/LineEndConcatenation

  Evan-M

  committed
  f980353

Commits on Apr 2, 2018

• Fix Layout/BlockAlignment

  dks17

  committed
  bb57a6a

• Fix Style/UnneededInterpolation

  dks17

  committed
  ede2ff9

• Fix Style/UnlessElse

  dks17

  committed
  5aaccab

• Fix Style/RedundantReturn

  dks17

  committed
  7f77c34

Commits on Apr 10, 2018

• Update rubocop todo list.

  Evan-M

  committed
  424bef0

• Fix Layout/MultilineOperationIndentation.

  Evan-M

  committed
  a35e4c7

• Update Layout/MultilineMethodCallIndentation to enforce indents_relative_to_receiver

  Evan-M

  committed
  1e3b2ff

Commits on Apr 27, 2018

• Setup appraisal for Rails 4.2

  

  krzysiek1507

  authored and

  dks17

  committed
  08652f8

• Polyfill Rails 5 versioned migrations

  

  krzysiek1507

  authored and

  dks17

  committed
  e534e0d

• Fallback http helpers for Rails 4 in tests

  

  krzysiek1507

  authored and

  dks17

  committed
  24b9208

• Fix tests on Rails 4

  

  krzysiek1507

  authored and

  dks17

  committed
  b982db4

• rebase

  dks17

  committed
  6f41e18

• update rubocop

  dks17

  committed
  a2a67f0

• update todo list

  Show description for 5c96cb8
  dks17

  committed
  5c96cb8

• Fix Style/StringLiterals

  dks17

  committed
  61c582b

• Fix wrong resolves of conflict

  dks17

  committed
  8f46f25

• Add rubocop gem into rails_version_gemfiles

  dks17

  committed
  4be88a1