Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove params that are not being used in resource params #1029

Conversation

MaicolBen
Copy link
Collaborator

Redone #719, thanks to @jahammo2

jahammo2 and others added 2 commits August 30, 2016 19:19
…b.com:jahammo2/devise_token_auth into update_resource_params_in_password_controller
@zachfeldman
Copy link
Contributor

Makes sense to me. We only need UID of some kind and reset password token to do the work of that endpoint. Merging.

@zachfeldman zachfeldman merged commit 4b1f20a into lynndylanhurley:master Nov 26, 2017
@mrkrlli
Copy link
Contributor

mrkrlli commented Apr 4, 2019

@zachfeldman @MaicolBen

If we still allow the user to pass in redirect_url as a param for the POST request to /auth/password, wouldn't we still need to permit the redirect_url parameter? Otherwise an unpermitted parameter error is thrown.

It's a bit confusing, since the docs for the endpoint still say to pass in redirect_url, which would be required if the user doesn't set a default in the initializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants