Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omniauth: when redirecting, user object should not be serialized into url #368

Closed
nbrustein opened this issue Sep 1, 2015 · 0 comments · Fixed by #371
Closed

omniauth: when redirecting, user object should not be serialized into url #368

nbrustein opened this issue Sep 1, 2015 · 0 comments · Fixed by #371

Comments

@nbrustein
Copy link
Contributor

in render_data_or_redirect, we only want to include the user object in the data when using newWindow or inAppBrowser. In the sameWindow case, ng-token-auth is going to make separate api call anyway to load up the user.

This defends against problems caused by a big user object leading to a big url.

It could be a breaking change for people not using ng-token-auth
@nbrustein nbrustein mentioned this issue Sep 2, 2015
Merged
booleanbetrayal added a commit that referenced this issue Sep 2, 2015
@booleanbetrayal
Merge pull request #371 from nbrustein/do-not-serialize-user-in-oauth…
76da2da 
…-redirect-url

fix(oauth): fixes #368: do not serialize the entire user object in the url when redirecting from oauth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nbrustein