Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter chain halted as :require_no_authentication #27

Closed
smarquez1 opened this issue Sep 11, 2014 · 10 comments
Closed

Filter chain halted as :require_no_authentication #27

smarquez1 opened this issue Sep 11, 2014 · 10 comments

Comments

@smarquez1
Copy link

I'm getting the following error when I try to logout/update account/destroy account/change password, being logged by Omniauth or not:

´´´ruby
Redirected to http://localhost:9000/
Filter chain halted as :require_no_authentication rendered or redirected
Completed 302 Found
´´´

Using:
´´´
gem 'devise_token_auth', '0.1.28.beta4'
"ng-token-auth": "0.0.22-beta1",
´´´

Any idea of why this is happening?

@lynndylanhurley
Copy link
Owner

That error is usually caused by an infinite before_filter or after_filter loop in Rails.

I'm using the same versions on the demo app, and the error isn't happening there. Are there any notable differences between your app and the demo app?

@smarquez1
Copy link
Author

I've been trying to spot a notable difference between the demo app and mine and there are none really. Do you still have a that old copy of my app locally?

@lynndylanhurley
Copy link
Owner

I think the problem may be related to your STI setup. I'll write a test to
verify.
On Sep 13, 2014 4:09 PM, "Sergio Márquez" [email protected] wrote:

I've been trying to spot a notable difference between the demo app and
mine and there are none really. Do you still have a that old copy of my app
locally?


Reply to this email directly or view it on GitHub
#27 (comment)
.

@smarquez1
Copy link
Author

I don't think so. I also test it in another application I'm working on, which does not use STI for users and the error appears when I update from 1.27 to 1.28 .
Could it be related to the fact that I have my grunt server running at locahost:9000, communicating to the rails API trough a proxy? Maybe it has to be with the way devise_token_auth it parses parameters in its controllers?

@lynndylanhurley
Copy link
Owner

It looks like this devise method was causing the problem. I don't think the method is relevant to this module so I've disabled it. I'm not sure why this wasn't causing problems before.

The fix is on master now, and I'll push a new version to rubygems soon.

@smarquez1
Copy link
Author

Fantastic, I'll try it out tomorrow cloning master. Thanks so much

@lynndylanhurley
Copy link
Owner

ng-token-auth version 0.0.22-beta2 and devise_token_auth version 0.1.28.beta5 should contain the fixes for this. Let me know if you run into any trouble.

@smarquez1
Copy link
Author

Thanks Lynn, it works very well but it looks like I've lost the ability to send params when I want to authenticate trough omniauth lynndylanhurley/ng-token-auth#31

@lynndylanhurley
Copy link
Owner

Have the params been whitelisted for devise? I'm using the devise_parameter_sanitizer.for(:sign_up) list for OAuth authentication.

@smarquez1
Copy link
Author

Yes. I think this started happening on 1.28 betas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants