Skip to content

Commit

Permalink
Merge pull request #466 from ValentinTrinque/fix-locales
Browse files Browse the repository at this point in the history
Fix locales `errors.messages.already_in_use` + clean up
  • Loading branch information
booleanbetrayal committed Dec 14, 2015
2 parents 785f77a + fb5ba8e commit 7a8f08a
Show file tree
Hide file tree
Showing 11 changed files with 123 additions and 123 deletions.
4 changes: 2 additions & 2 deletions app/controllers/devise_token_auth/registrations_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,11 @@ def resource_update_method
end

def validate_sign_up_params
validate_post_data sign_up_params, I18n.t("errors.validate_sign_up_params")
validate_post_data sign_up_params, I18n.t("errors.messages.validate_sign_up_params")
end

def validate_account_update_params
validate_post_data account_update_params, I18n.t("errors.validate_account_update_params")
validate_post_data account_update_params, I18n.t("errors.messages.validate_account_update_params")
end

def validate_post_data which, message
Expand Down
6 changes: 3 additions & 3 deletions app/models/devise_token_auth/concerns/user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,12 @@ def create_new_auth_token(client_id=nil)
last_token: last_token,
updated_at: Time.now
}

max_clients = DeviseTokenAuth.max_number_of_devices
while self.tokens.keys.length > 0 and max_clients < self.tokens.keys.length
oldest_token = self.tokens.min_by { |cid, v| v[:expiry] || v["expiry"] }
self.tokens.delete(oldest_token.first)
end
end

self.save!

Expand Down Expand Up @@ -239,7 +239,7 @@ def token_validation_response
# only validate unique email among users that registered by email
def unique_email_user
if provider == 'email' and self.class.where(provider: 'email', email: email).count > 0
errors.add(:email, :already_in_use)
errors.add(:email, I18n.t("errors.messages.already_in_use"))
end
end

Expand Down
12 changes: 6 additions & 6 deletions app/validators/email_validator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ def validate_each(record, attribute, value)
record.errors[attribute] << email_invalid_message
end
end

private

def email_invalid_message
# Try strictly set message:
message = options[:message]

if message.nil?
# Try DeviceTokenAuth translations or fallback to ActiveModel translations
message = I18n.t(:'errors.not_email', default: :'errors.messages.invalid')
message = I18n.t(:'errors.messages.not_email', default: :'errors.messages.invalid')
end

message
end
end
end
24 changes: 12 additions & 12 deletions config/locales/de.yml
Original file line number Diff line number Diff line change
@@ -1,33 +1,33 @@
de:
devise_token_auth:
sessions:
not_confirmed: "Ein E-Mail zu Bestätigung wurde an Ihre Adresse %{email} gesendet. Sie müssen den Anleitungsschritten im E-Mail folgen, um Ihren Account zu aktivieren"
not_confirmed: "Ein E-Mail zu Bestätigung wurde an Ihre Adresse '%{email}'' gesendet. Sie müssen den Anleitungsschritten im E-Mail folgen, um Ihren Account zu aktivieren"
bad_credentials: "Ungültige Anmeldeinformationen. Bitte versuchen Sie es erneut."
not_supported: "Verwenden Sie POST /sign_in zur Anmeldung. GET wird nicht unterstützt."
user_not_found: "Benutzer wurde nicht gefunden oder konnte nicht angemeldet werden."
token_validations:
invalid: "Ungültige Anmeldeinformationen"
registrations:
missing_confirm_success_url: "Fehlender Paramter `confirm_success_url`."
redirect_url_not_allowed: "Weiterleitung zu %{redirect_url} ist nicht gestattet."
email_already_exists: "Es gibt bereits einen Account für %{email}."
account_with_uid_destroyed: "Account mit der uid %{uid} wurde gelöscht."
missing_confirm_success_url: "Fehlender Paramter 'confirm_success_url'."
redirect_url_not_allowed: "Weiterleitung zu '%{redirect_url}' ist nicht gestattet."
email_already_exists: "Es gibt bereits einen Account für '%{email}'."
account_with_uid_destroyed: "Account mit der uid '%{uid}' wurde gelöscht."
account_to_destroy_not_found: "Der Account, der gelöscht werden soll, kann nicht gefunden werden."
user_not_found: "Benutzer kann nicht gefunden werden."
passwords:
missing_email: "Sie müssen eine E-Mail Adresse angeben."
missing_redirect_url: "Es fehlt der URL zu Weiterleitung."
not_allowed_redirect_url: "Weiterleitung zu %{redirect_url} ist nicht gestattet."
sended: "Ein E-Mail mit Anleitung zum Rücksetzen Ihres Passwortes wurde an %{email} gesendet."
not_allowed_redirect_url: "Weiterleitung zu '%{redirect_url}' ist nicht gestattet."
sended: "Ein E-Mail mit Anleitung zum Rücksetzen Ihres Passwortes wurde an '%{email}' gesendet."
user_not_found: "Der Benutzer mit E-Mail-Adresse '%{email}' kann nicht gefunden werden."
password_not_required: "Dieser Account benötigt kein Passwort. Melden Sie Sich stattdessen über Ihren Account bei %{provider} an."
missing_passwords: 'Sie müssen die Felder "Passwort" and "Passwortbestätigung" ausfüllen.'
password_not_required: "Dieser Account benötigt kein Passwort. Melden Sie Sich stattdessen über Ihren Account bei '%{provider}' an."
missing_passwords: "Sie müssen die Felder 'Passwort' and 'Passwortbestätigung' ausfüllen."
successfully_updated: "Ihr Passwort wurde erfolgreich aktualisiert."
errors:
validate_sign_up_params: "Bitte übermitteln sie vollständige Anmeldeinformationen im Body des Requests."
validate_account_update_params: "Bitte übermitteln sie vollständige Informationen zur Aktualisierung im Body des Requests."
not_email: "ist keine E-Mail Adresse"
messages:
validate_sign_up_params: "Bitte übermitteln sie vollständige Anmeldeinformationen im Body des Requests."
validate_account_update_params: "Bitte übermitteln sie vollständige Informationen zur Aktualisierung im Body des Requests."
not_email: "ist keine E-Mail Adresse"
already_in_use: "bereits in Verwendung"
devise:
mailer:
Expand Down
40 changes: 20 additions & 20 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
@@ -1,47 +1,47 @@
en:
devise_token_auth:
sessions:
not_confirmed: "A confirmation email was sent to your account at %{email}. You must follow the instructions in the email before your account can be activated"
not_confirmed: "A confirmation email was sent to your account at '%{email}'. You must follow the instructions in the email before your account can be activated"
bad_credentials: "Invalid login credentials. Please try again."
not_supported: "Use POST /sign_in to sign in. GET is not supported."
user_not_found: "User was not found or was not logged in."
token_validations:
invalid: "Invalid login credentials"
registrations:
missing_confirm_success_url: "Missing `confirm_success_url` param."
redirect_url_not_allowed: "Redirect to %{redirect_url} not allowed."
email_already_exists: "An account already exists for %{email}"
account_with_uid_destroyed: "Account with uid %{uid} has been destroyed."
missing_confirm_success_url: "Missing 'confirm_success_url' parameter."
redirect_url_not_allowed: "Redirect to '%{redirect_url}' not allowed."
email_already_exists: "An account already exists for '%{email}'"
account_with_uid_destroyed: "Account with UID '%{uid}' has been destroyed."
account_to_destroy_not_found: "Unable to locate account for destruction."
user_not_found: "User not found."
passwords:
missing_email: "You must provide an email address."
missing_redirect_url: "Missing redirect url."
not_allowed_redirect_url: "Redirect to %{redirect_url} not allowed."
sended: "An email has been sent to %{email} containing instructions for resetting your password."
missing_redirect_url: "Missing redirect URL."
not_allowed_redirect_url: "Redirect to '%{redirect_url}' not allowed."
sended: "An email has been sent to '%{email}' containing instructions for resetting your password."
user_not_found: "Unable to find user with email '%{email}'."
password_not_required: "This account does not require a password. Sign in using your %{provider} account instead."
missing_passwords: 'You must fill out the fields labeled "password" and "password confirmation".'
password_not_required: "This account does not require a password. Sign in using your '%{provider}' account instead."
missing_passwords: "You must fill out the fields labeled 'Password' and 'Password confirmation'."
successfully_updated: "Your password has been successfully updated."
errors:
validate_sign_up_params: "Please submit proper sign up data in request body."
validate_account_update_params: "Please submit proper account update data in request body."
not_email: "is not an email"
messages:
already_in_use: already in use
already_in_use: "already in use"
validate_sign_up_params: "Please submit proper sign up data in request body."
validate_account_update_params: "Please submit proper account update data in request body."
not_email: "is not an email"
devise:
mailer:
confirmation_instructions:
confirm_link_msg: "You can confirm your account email through the link below:"
confirm_account_link: Confirm my account
confirm_account_link: "Confirm my account"
reset_password_instructions:
request_reset_link_msg: "Someone has requested a link to change your password. You can do this through the link below."
password_change_link: Change my password
password_change_link: "Change my password"
ignore_mail_msg: "If you didn't request this, please ignore this email."
no_changes_msg: "Your password won't change until you access the link above and create a new one."
unlock_instructions:
account_lock_msg: Your account has been locked due to an excessive number of unsuccessful sign in attempts.
account_lock_msg: "Your account has been locked due to an excessive number of unsuccessful sign in attempts."
unlock_link_msg: "Click the link below to unlock your account:"
unlock_link: Unlock my account
hello: hello
welcome: welcome
unlock_link: "Unlock my account"
hello: "hello"
welcome: "welcome"
48 changes: 24 additions & 24 deletions config/locales/es.yml
Original file line number Diff line number Diff line change
@@ -1,50 +1,50 @@
es:
devise_token_auth:
sessions:
not_confirmed: "Un correo electrónico de confirmación de su cuenta ha sido enviado a %{email}. Por favor, siga las instrucciones para validar su cuenta"
not_confirmed: "Un correo electrónico de confirmación de su cuenta ha sido enviado a '%{email}'. Por favor, siga las instrucciones para validar su cuenta"
bad_credentials: "Identidad o contraseña no válida."
not_supported: "Use POST /sign_in para la conexión. GET no esta disponible."
user_not_found: "Usuario desconocido o no está conectado."
token_validations:
invalid: "Identidad o contraseña no válida."
registrations:
missing_confirm_success_url: "El parámetro `confirm_success_url` no esta presente."
redirect_url_not_allowed: "Redirección hacia %{redirect_url} no esta permitida."
email_already_exists: "Una cuenta ya existe con este correo electrónico: %{email}"
account_with_uid_destroyed: "La cuenta con el identificador %{uid} se ha eliminado."
missing_confirm_success_url: "El parámetro 'confirm_success_url' no esta presente."
redirect_url_not_allowed: "Redirección hacia '%{redirect_url}' no esta permitida."
email_already_exists: "Una cuenta ya existe con este correo electrónico '%{email}'"
account_with_uid_destroyed: "La cuenta con el identificador '%{uid}' se ha eliminado."
account_to_destroy_not_found: "No se puede encontrar la cuenta a borrar."
user_not_found: "Usuario no encontrado."
passwords:
missing_email: "Debe incluir un correo electrónico."
missing_redirect_url: "Falta el Url de redirección."
not_allowed_redirect_url: "Redirección hacia %{redirect_url} no esta permitida."
sended: "Un correo electrónico ha sido enviado a %{email} con las instrucciones para restablecer su contraseña."
user_not_found: "No se pudo encontrar un usuario con este correo electrónico: '%{email}'."
password_not_required: "Esta cuenta no requiere contraseña. Iniciar sesión utilizando %{provider}."
missing_passwords: 'Debe llenar los campos "contraseña" y "confirmación de contraseña".'
not_allowed_redirect_url: "Redirección hacia '%{redirect_url}' no esta permitida."
sended: "Un correo electrónico ha sido enviado a '%{email}' con las instrucciones para restablecer su contraseña."
user_not_found: "No se pudo encontrar un usuario con este correo electrónico '%{email}'."
password_not_required: "Esta cuenta no requiere contraseña. Iniciar sesión utilizando '%{provider}'."
missing_passwords: "Debe llenar los campos 'Contraseña' y 'Confirmación de contraseña'."
successfully_updated: "Su contraseña ha sido actualizada con éxito."
errors:
validate_sign_up_params: "Los datos introducidos en la solicitud de acceso no son válidos."
validate_account_update_params: "Los datos introducidos en la solicitud de actualización no son válidos."
not_email: "no es un correo electrónico"
messages:
already_in_use: ya ha sido ocupado
validate_sign_up_params: "Los datos introducidos en la solicitud de acceso no son válidos."
validate_account_update_params: "Los datos introducidos en la solicitud de actualización no son válidos."
not_email: "no es un correo electrónico"
already_in_use: "ya ha sido ocupado"
devise:
mailer:
confirmation_instructions:
subject: Instrucciones de confirmación
subject: "Instrucciones de confirmación"
confirm_link_msg: "Para confirmar su cuenta ingrese en el siguiente link:"
confirm_account_link: Confirmar cuenta
confirm_account_link: "Confirmar cuenta"
reset_password_instructions:
subject: Instrucciones para restablecer su contraseña
subject: "Instrucciones para restablecer su contraseña"
request_reset_link_msg: "Ha solicitado un cambio de contraseña. Para continuar ingrese en el siguiente link:"
password_change_link: Cambiar contraseña
ignore_mail_msg: Por favor ignore este mensaje si no ha solicitado esta acción.
password_change_link: "Cambiar contraseña"
ignore_mail_msg: "Por favor ignore este mensaje si no ha solicitado esta acción."
no_changes_msg: "Importante: Su contraseña no será actualizada a menos que ingrese en el link."
unlock_instructions:
subject: Instrucciones de desbloqueo
account_lock_msg: Su cuenta ha sido bloqueada debido a sucesivos intentos de ingresos fallidos
subject: "Instrucciones de desbloqueo"
account_lock_msg: "Su cuenta ha sido bloqueada debido a sucesivos intentos de ingresos fallidos"
unlock_link_msg: "Para desbloquear su cuenta ingrese en el siguiente link:"
unlock_link: Desbloquear cuenta
hello: hola
welcome: bienvenido
unlock_link: "Desbloquear cuenta"
hello: "hola"
welcome: "bienvenido"
34 changes: 17 additions & 17 deletions config/locales/fr.yml
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
fr:
devise_token_auth:
sessions:
not_confirmed: "Un e-mail de confirmation de votre compte a été envoyé à %{email}. Merci de suivre les instructions afin de valider votre compte"
not_confirmed: "Un e-mail de confirmation de votre compte a été envoyé à '%{email}'. Merci de suivre les instructions afin de valider votre compte"
bad_credentials: "Mot de passe ou identifiant invalide."
not_supported: "Utilisez POST /sign_in pour la connexion. GET n'est pas supporté."
user_not_found: "L'utilisateur est inconnu ou n'est pas connecté."
token_validations:
invalid: "Mot de passe ou identifiant invalide."
registrations:
missing_confirm_success_url: "Le paramètre `confirm_success_url` est manquant."
redirect_url_not_allowed: "Redirection vers %{redirect_url} n'est pas autorisée."
email_already_exists: "Un compte existe déjà avec cette addresse e-mail: %{email}"
account_with_uid_destroyed: "Le compte avec l'identifiant %{uid} a été supprimé."
missing_confirm_success_url: "Le paramètre 'confirm_success_url' est manquant."
redirect_url_not_allowed: "Redirection vers '%{redirect_url}' n'est pas autorisée."
email_already_exists: "Un compte existe déjà avec l'adresse e-mail suivante '%{email}'"
account_with_uid_destroyed: "Le compte avec l'identifiant '%{uid}' a été supprimé."
account_to_destroy_not_found: "Le compte à supprimer est introuvable."
user_not_found: "Utilisateur introuvable."
passwords:
missing_email: "Vous devez soumettre un e-mail."
missing_redirect_url: "URL de redirection manquante."
not_allowed_redirect_url: "Redirection vers %{redirect_url} n'est pas autorisée."
sended: "Un e-mail a été envoyé à %{email} avec les instructions de réinitialisation du mot de passe."
user_not_found: "Impossible de trouver l'utilisateur avec l'adresse e-mail: '%{email}'."
password_not_required: "Ce compte ne demande pas de mot de passe. Connectez vous en utilisant %{provider}."
missing_passwords: 'Vous devez remplir les champs "mot de passe" et "confirmation de mot de passe".'
not_allowed_redirect_url: "Redirection vers '%{redirect_url}' n'est pas autorisée."
sended: "Un e-mail a été envoyé à '%{email}' avec les instructions de réinitialisation du mot de passe."
user_not_found: "Impossible de trouver l'utilisateur avec l'adresse e-mail suivante '%{email}'."
password_not_required: "Ce compte ne demande pas de mot de passe. Connectez vous en utilisant '%{provider}'."
missing_passwords: "Vous devez remplir les champs 'Mot de passe' et 'Confirmation de mot de passe'."
successfully_updated: "Votre mot de passe a été correctement mis à jour."
errors:
validate_sign_up_params: "Les données d'inscription dans le corps de la requête ne sont pas valides."
validate_account_update_params: "Les données de mise à jour dans le corps de la requête ne sont pas valides."
not_email: "n'est pas une adresse e-mail"
messages:
already_in_use: "déjà utilisé"
already_in_use: "déjà utilisé(e)"
validate_sign_up_params: "Les données d'inscription dans le corps de la requête ne sont pas valides."
validate_account_update_params: "Les données de mise à jour dans le corps de la requête ne sont pas valides."
not_email: "n'est pas une adresse e-mail"
devise:
mailer:
confirmation_instructions:
Expand All @@ -43,8 +43,8 @@ fr:
no_changes_msg: "Votre mot de passe ne changera pas tant que vous n'accédez pas au lien ci-dessus pour en créer un nouveau."
unlock_instructions:
subject: "Instructions de déblocage"
account_lock_msg: "Votre compte a été bloqué en raison de nombreuses tentatives de connection erronées."
account_lock_msg: "Votre compte a été bloqué en raison de nombreuses tentatives de connexion erronées."
unlock_link_msg: "Cliquez sur le lien ci-dessous pour déverrouiller votre compte:"
unlock_link: "Déverrouiller mon compte"
hello: bonjour
welcome: bienvenue
hello: "bonjour"
welcome: "bienvenue"
Loading

0 comments on commit 7a8f08a

Please sign in to comment.