Skip to content

Commit

Permalink
Update rubocop todo list and exclusions.
Browse files Browse the repository at this point in the history
  • Loading branch information
Evan-M committed Mar 27, 2018
1 parent 1502526 commit 7610d26
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 23 deletions.
2 changes: 2 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ inherit_from: .rubocop_todo.yml
AllCops:
Exclude:
- 'coverage/**/*'
- 'test/dummy/tmp/**/*'
- 'test/dummy/log/**/*'

# Offense count: 130
# Cop supports --auto-correct.
Expand Down
58 changes: 35 additions & 23 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 30`
# on 2018-03-23 19:22:33 -0700 using RuboCop version 0.54.0.
# `rubocop --auto-gen-config --exclude-limit 100`
# on 2018-03-27 14:56:41 -0700 using RuboCop version 0.54.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -29,6 +29,13 @@ Layout/AlignParameters:
- 'test/dummy/config/initializers/omniauth.rb'
- 'test/dummy/config/routes.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleAlignWith.
# SupportedStylesAlignWith: either, start_of_block, start_of_line
Layout/BlockAlignment:
Exclude:
- 'test/controllers/demo_user_controller_test.rb'

# Offense count: 2
# Cop supports --auto-correct.
Expand All @@ -43,13 +50,14 @@ Layout/EmptyLinesAroundAccessModifier:
Exclude:
- 'app/controllers/devise_token_auth/unlocks_controller.rb'

# Offense count: 4
# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: empty_lines, no_empty_lines
Layout/EmptyLinesAroundBlockBody:
Exclude:
- 'app/controllers/devise_token_auth/concerns/set_user_by_token.rb'
- 'test/controllers/demo_user_controller_test.rb'
- 'test/controllers/devise_token_auth/passwords_controller_test.rb'
- 'test/dummy/db/schema.rb'

Expand Down Expand Up @@ -110,7 +118,7 @@ Layout/IndentationConsistency:
Exclude:
- 'test/dummy/tmp/generators/config/routes.rb'

# Offense count: 4
# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: Width, IgnoredPatterns.
Layout/IndentationWidth:
Expand Down Expand Up @@ -141,13 +149,22 @@ Layout/MultilineBlockLayout:
Exclude:
- 'lib/generators/devise_token_auth/install_generator.rb'

# Offense count: 6
# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented, indented_relative_to_receiver
Layout/MultilineMethodCallIndentation:
Exclude:
- 'test/controllers/devise_token_auth/sessions_controller_test.rb'

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented
Layout/MultilineOperationIndentation:
Exclude:
- 'app/controllers/devise_token_auth/concerns/set_user_by_token.rb'
- 'app/models/devise_token_auth/concerns/user.rb'
- 'lib/generators/devise_token_auth/install_generator.rb'

# Offense count: 1
Expand Down Expand Up @@ -217,7 +234,6 @@ Layout/SpaceInsideBlockBraces:
- 'lib/devise_token_auth/rails/routes.rb'
- 'test/lib/generators/devise_token_auth/install_generator_test.rb'


# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Expand All @@ -229,12 +245,6 @@ Layout/TrailingBlankLines:
- 'test/dummy/lib/migration_database_helper.rb'
- 'test/integration/navigation_test.rb'

# Offense count: 1
# Cop supports --auto-correct.
Layout/TrailingWhitespace:
Exclude:
- 'lib/generators/devise_token_auth/install_generator.rb'

# Offense count: 1
Lint/AmbiguousBlockAssociation:
Exclude:
Expand Down Expand Up @@ -268,12 +278,13 @@ Lint/StringConversionInInterpolation:
Exclude:
- 'app/controllers/devise_token_auth/concerns/resource_finder.rb'

# Offense count: 5
# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
Exclude:
- 'app/models/devise_token_auth/concerns/user.rb'
- 'test/controllers/demo_user_controller_test.rb'
- 'test/controllers/devise_token_auth/sessions_controller_test.rb'
- 'test/dummy/app/controllers/custom/registrations_controller.rb'
- 'test/dummy/config/initializers/omniauth.rb'
Expand Down Expand Up @@ -305,7 +316,7 @@ Lint/Void:
Metrics/AbcSize:
Max: 74

# Offense count: 94
# Offense count: 95
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/BlockLength:
Max: 696
Expand Down Expand Up @@ -435,10 +446,11 @@ Style/ColonMethodCall:
- 'lib/devise_token_auth/engine.rb'
- 'lib/devise_token_auth/rails/routes.rb'

# Offense count: 2
# Offense count: 3
Style/CommentedKeyword:
Exclude:
- 'app/controllers/devise_token_auth/concerns/set_user_by_token.rb'
- 'test/controllers/demo_user_controller_test.rb'

# Offense count: 3
# Cop supports --auto-correct.
Expand Down Expand Up @@ -629,15 +641,14 @@ Style/Not:
Style/NumericLiterals:
MinDigits: 15

# Offense count: 3
# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle.
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
Exclude:
- 'spec/**/*'
- 'app/controllers/devise_token_auth/confirmations_controller.rb'
- 'app/models/devise_token_auth/concerns/user.rb'
- 'test/dummy/app/models/user.rb'

# Offense count: 3
Expand Down Expand Up @@ -745,6 +756,12 @@ Style/TernaryParentheses:
- 'lib/generators/devise_token_auth/install_generator.rb'
- 'test/lib/generators/devise_token_auth/install_generator_test.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Exclude:
- 'test/controllers/devise_token_auth/sessions_controller_test.rb'

# Offense count: 4
# Cop supports --auto-correct.
Expand Down Expand Up @@ -777,13 +794,8 @@ Style/WordArray:
- 'app/controllers/devise_token_auth/omniauth_callbacks_controller.rb'
- 'test/dummy/db/schema.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Exclude:
- 'app/models/devise_token_auth/concerns/user.rb'

# Offense count: 326
# Offense count: 325
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
Expand Down

0 comments on commit 7610d26

Please sign in to comment.