This repository has been archived by the owner on May 17, 2024. It is now read-only.
Support Array Of Fields For Custom Transformation #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduan
force-pushed
the
array_transformation
branch
from
5e1ce76 to
63c2d8c
Compare
keith
approved these changes
Oct 6, 2017
Sources/Mapper.swift
Outdated
| /// otherwise nil | ||
| public func optionalFrom<T>(_ fields: [String], transformation: (Any) throws -> T?) -> T? { | ||
| for field in fields { | ||
| if let value = try? transformation((try self.JSONFromField(field))) { |
Sources/Mapper.swift
Outdated
| if let value = try? transformation((try self.JSONFromField(field))) { | ||
| return value | ||
| } | ||
| } |
|
Also please add a changelog entry |
keith
reviewed
Oct 6, 2017
| } | ||
|
|
||
| let test = try? Test(map: Mapper(JSON: ["a": "##", "b": 1])) | ||
| XCTAssertNil(test?.value) |
There was a problem hiding this comment.
Can you adjust these tests to be like the ones above these new ones, we want to make sure that test is non-nil, but value is, so we should catch the try with an XCTFail
|
added change log. |
|
Now I'll squash. |
Returns `nil` if key doesn't exist or transformation for found value throws.
dduan
force-pushed
the
array_transformation
branch
from
6d12620 to
a38b607
Compare
|
Pushed 7.2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns
nilif key doesn't exist or transformation for found value throws.