Merge apache 8847e10 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"dashboards" 有的翻译成"看板", 有的翻译成"仪表盘". 为了统一现在全部改为"看板".
* chore: deprecate restricted metrics An early community contribution added the concept of restricted metrics. The idea was to allow for some metrics to be restricted, and if a metric was tagged as such, a user would need to be given access to that metric more explicitely, through a special perm we would maintain for that metric. Now since the new concept of "Adhoc Metrics", the popover that lets a user pick a column and an aggregate function or to write their own SQL expression inline, this restriction is completely bypassed. Adhoc metrics was developed without the restricted metrics in mind. Anyhow, in the near future, we'll be rethinking the ideas behind data-access permissions, and things like column-level or row-level security will be redesigned from scratch. By deprecating this feature, we're removing a confusing and mostly broken feature, and making it easy to move forward * Use context manager to drop columns * disable jest's maxWorkers
Also documenting this step under RELEASING/README.md
Corrected typos
…rts when filter options are open/close (apache#8166) * show ellipsis for long filter name in tooltip * show filter indicator color bar when filter is applied * show/hide filter indicator when filter is showing/hiding options * use component local state to hide/show chart outline * fix review comments + unit tests
* fix: attempt to fix the flaky SQL Lab test https://docs.cypress.io/api/commands/clear.html#Syntax doubling our chances to selectall and clear the text box * Add {force: true} * fix typo * more clears
* Fix version info Ran into Cypress issues while getting too ambitious in apache#8157 this is a simplified more targeted version of it * include package.json (but not under static/) * use package.json as single source of truth for version info * typo
* feat: read control panel configs from registry * fix: order imports * fix: remove index.js and get items on-the-fly, remove extraOverrides * fix: lint * fix: unit tests * fix: unit tests * fix: lint * fix: unit tests
…pache#8222) * move paired t-test * fix: remove nvd3sections * move more controls
* Handle int64 columns with missing data in SQL Lab * Fix docstring * Add unit test * Small fix * Small fixes * Fix cursor description update * Better fix * Fix unit test, black * Fix nan comparison in unit test
* WIP * Basic functionality working * Enable per DB * Show error message * Small improvements * Fix lint * Address comments * Address comments * Remove logging, fix exception * Fix tests * Bump FAB requirements
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a refactoring to migrate control panels to plugins. I updated superset/assets/src/setup/setupPlugins.ts to include Kepler in an additional commit (56f35e9) and fixed the import order in another commit (625cd88).