Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default tooltips to deck.gl viz types #20

Closed
wants to merge 1 commit into from
Closed

Conversation

khtruong
Copy link

@khtruong khtruong commented Apr 2, 2019

SUMMARY

Add default tooltips to deck.gl viz types. If the user specifies his or her own custom tooltips, we use those tooltips instead. Note that in geojson and path vizs, the user must specify the extra props. This isn't really that discoverable so we should perhaps think of improving that experience.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Arc Viz
Screen Shot 2019-04-01 at 9 41 56 PM

Grid Viz
Screen Shot 2019-04-01 at 9 43 57 PM

Hex Viz
Screen Shot 2019-04-01 at 9 44 42 PM

Scatter Plot
Screen Shot 2019-04-01 at 9 45 56 PM

TEST PLAN

Manual testing

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[x] Introduces new feature or API
[ ] Removes existing feature or API
[ ] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@xtinec @betodealmeida @kristw @williaster

@khtruong
Copy link
Author

khtruong commented Apr 2, 2019

@vylc Here are a few screenshots of the tooltips.

@vylc
Copy link

vylc commented Apr 2, 2019

looks good!
(1) can i get a screenshot of what this looks like when the metric is a decimal value? ideally, inheriting the formatting from the metric or viz config would be great, but that might be too much work given the timeframe. let's just make sure it wraps and doesn't roll out of the tooltip.
(2) Assuming these changes also affect deck.gl polygon, which already has a tooltip, but if there were any enhancements made, let's just make sure that one is consistent, too.
THANKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants