Add support for pulling routes from subnet route table #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulFurtado
force-pushed
the
route_subet_gw
branch
from
c57adb7 to
8761b48
Compare
|
Hi @PaulFurtado - I haven't had a chance to test this on our infrastructure yet - will report back on if we find any issues here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in my comment on the VPC peering routes PR, this adds support for pulling routes from the routing table associated with the subnet of the ENI.
Note that I'm very new to Go, so definitely let me know if I'm doing anything weird or not meeting your style guidelines, I'm more than happy to make any changes. Thanks!