github/workflows: migrate CI to Go 1.19 and fix linting issues (#2426)

lyft · Nov 14, 2022 · 9aa9e74 · 9aa9e74
1 parent beef59d
commit 9aa9e74
Show file tree

Hide file tree

Showing 54 changed files with 157 additions and 125 deletions.
diff --git a/.github/workflows/api.yml b/.github/workflows/api.yml
@@ -22,7 +22,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17.0
+          go-version: 1.19.x
       - name: Set up Node
         uses: actions/setup-node@v3
         with:
@@ -36,6 +36,6 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17.0
+          go-version: 1.19.x
       - name: lint
         run: make api-lint
diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
@@ -17,22 +17,23 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
+        id: setup-go
         with:
-          go-version: 1.17.0
+          go-version: 1.19.x
       - name: go mod cache
         uses: actions/cache@v3
         with:
           path: |
             ~/go/pkg/mod
-          key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-mod-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-mod-
       - name: go build cache
         uses: actions/cache@v3
         with:
           path: |
             ~/.cache/go-build
-          key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-build-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-build-
       - run: make backend
@@ -41,22 +42,23 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
+        id: setup-go
         with:
-          go-version: 1.17.0
+          go-version: 1.19.x
       - name: go mod cache
         uses: actions/cache@v3
         with:
           path: |
             ~/go/pkg/mod
-          key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-mod-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-mod-
       - name: go test cache
         uses: actions/cache@v3
         with:
           path: |
             ~/.cache/go-build
-          key: ${{ runner.os }}-go-test-${{ hashFiles('**/go.sum') }}
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-test-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-test-
       - run: make backend-test
@@ -73,14 +75,15 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
+        id: setup-go
         with:
-          go-version: 1.17.0
+          go-version: 1.19.x
       - name: go mod cache
         uses: actions/cache@v3
         with:
           path: |
             ~/go/pkg/mod
-          key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-mod-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-mod-
       - name: go lint cache
@@ -89,7 +92,7 @@ jobs:
           path: |
             ~/.cache/go-build
             ~/.cache/golangci-lint
-          key: ${{ runner.os }}-go-lint-${{ hashFiles('**/go.sum') }}
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-lint-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-lint-
       - run: make backend-lint

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -27,7 +27,7 @@ jobs:
           VERSION=latest
           TAGS="${DOCKER_IMAGE}:${VERSION}"
           TAGS="$TAGS,${DOCKER_IMAGE}:sha-${GITHUB_SHA::7}"
-          echo ::set-output name=tags::${TAGS}
+          echo "tags=${TAGS}" >>${GITHUB_OUTPUT}
       - name: build and push
         if: github.ref == 'refs/heads/main'
         uses: docker/[email protected]

diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml
@@ -80,8 +80,9 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
+        id: setup-go
         with:
-          go-version: 1.17.0
+          go-version: 1.19.x
       - uses: actions/setup-node@v3
         with:
           node-version: '16.x'
@@ -108,15 +109,15 @@ jobs:
         with:
           path: |
             ~/go/pkg/mod
-          key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}  
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-mod-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-mod-
       - name: go build cache
         uses: actions/cache@v3
         with:
           path: |
             ~/.cache/go-build
-          key: ${{ runner.os }}-go-mock-build-${{ hashFiles('**/go.sum') }}
+          key: ${{ runner.os }}-${{ steps.setup-go.outputs.go-version }}-go-mock-build-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-mock-build-
             ${{ runner.os }}-go-build-

diff --git a/.github/workflows/scaffolding.yml b/.github/workflows/scaffolding.yml
@@ -18,7 +18,7 @@ jobs:
           path: ${{ env.PACKAGEPATH }}
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17.0
+          go-version: 1.19.x
       - uses: actions/setup-node@v3
         with:
           node-version: '16.x'

diff --git a/backend/.golangci.yml b/backend/.golangci.yml
@@ -2,29 +2,28 @@
 linters:
   disable-all: true
   enable:
-  - deadcode
   - errcheck
   - exportloopref
   - gci
   - gocritic
   - gofmt
-  - goimports
   - gosec
   - gosimple
   - govet
   - ineffassign
   - staticcheck
-  - structcheck
   - typecheck
   - unused
-  - varcheck
   - whitespace
 linters-settings:
   gocritic:
     disabled-checks:
       - singleCaseSwitch
-  goimports:
-    local-prefixes: github.com/lyft/clutch/backend
+  gci:
+    sections:
+    - standard
+    - default
+    - prefix(github.com/lyft/clutch/backend)
 issues:
   max-per-linter: 0
   max-same-issues: 0

diff --git a/backend/api/audit/v1/audit.pb.go b/backend/api/audit/v1/audit.pb.go
diff --git a/backend/api/authn/v1/authn.pb.go b/backend/api/authn/v1/authn.pb.go
diff --git a/backend/api/chaos/experimentation/v1/properties.pb.go b/backend/api/chaos/experimentation/v1/properties.pb.go
diff --git a/backend/api/chaos/redisexperimentation/v1/redisexperimentation.pb.go b/backend/api/chaos/redisexperimentation/v1/redisexperimentation.pb.go
diff --git a/backend/api/chaos/serverexperimentation/v1/serverexperimentation.pb.go b/backend/api/chaos/serverexperimentation/v1/serverexperimentation.pb.go
diff --git a/backend/api/config/gateway/v1/gateway.pb.go b/backend/api/config/gateway/v1/gateway.pb.go
diff --git a/backend/api/config/middleware/accesslog/v1/accesslog.pb.go b/backend/api/config/middleware/accesslog/v1/accesslog.pb.go
diff --git a/backend/api/config/module/featureflag/v1/featureflag.pb.go b/backend/api/config/module/featureflag/v1/featureflag.pb.go
diff --git a/backend/api/config/service/audit/v1/audit.pb.go b/backend/api/config/service/audit/v1/audit.pb.go
diff --git a/backend/api/config/service/auditsink/slack/v1/slack.pb.go b/backend/api/config/service/auditsink/slack/v1/slack.pb.go
diff --git a/backend/api/config/service/authn/v1/authn.pb.go b/backend/api/config/service/authn/v1/authn.pb.go
diff --git a/backend/api/config/service/authz/v1/authz.pb.go b/backend/api/config/service/authz/v1/authz.pb.go
diff --git a/backend/api/config/service/db/postgres/v1/database.pb.go b/backend/api/config/service/db/postgres/v1/database.pb.go