Change SNTP cache mutating methods to be synchronized (#50)

lyft · Nov 23, 2020 · 789936c · 789936c
1 parent 21fa5b8
commit 789936c
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/kronos-java/src/main/java/com/lyft/kronos/internal/ntp/SntpResponseCache.kt b/kronos-java/src/main/java/com/lyft/kronos/internal/ntp/SntpResponseCache.kt
@@ -13,7 +13,10 @@ internal interface SntpResponseCache {
     fun clear()
 }
 
-internal class SntpResponseCacheImpl(private val syncResponseCache: SyncResponseCache, private val deviceClock: Clock) : SntpResponseCache {
+internal class SntpResponseCacheImpl(
+    private val syncResponseCache: SyncResponseCache,
+    private val deviceClock: Clock,
+) : SntpResponseCache {
 
     override fun get(): SntpClient.Response? {
         val currentTime = syncResponseCache.currentTime
@@ -26,12 +29,16 @@ internal class SntpResponseCacheImpl(private val syncResponseCache: SyncResponse
     }
 
     override fun update(response: SntpClient.Response) {
-        syncResponseCache.currentTime = response.deviceCurrentTimestampMs
-        syncResponseCache.elapsedTime = response.deviceElapsedTimestampMs
-        syncResponseCache.currentOffset = response.offsetMs
+        synchronized(this) {
+            syncResponseCache.currentTime = response.deviceCurrentTimestampMs
+            syncResponseCache.elapsedTime = response.deviceElapsedTimestampMs
+            syncResponseCache.currentOffset = response.offsetMs
+        }
     }
 
     override fun clear() {
-        syncResponseCache.clear()
+        synchronized(this) {
+            syncResponseCache.clear()
+        }
     }
 }