Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back connection pool #355

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Add back connection pool #355

merged 1 commit into from
Oct 8, 2021

Conversation

mre
Copy link
Member

@mre mre commented Oct 8, 2021

Fixes a regression in master, where performance dropped massively after removing the client pool.
See #349 (comment).
The reason is, that reqwest still blocks for every request that doesn't connect to the same host.

@mre mre merged commit 56726f4 into master Oct 8, 2021
@mre mre deleted the fp branch October 8, 2021 11:08
@MichaIng
Copy link
Member

MichaIng commented Oct 8, 2021

Run times on your repos are back to normal by this. Crazy how massive the effect, factor x60 on one repo, factor x17 on the other 😮.

@mre mre mentioned this pull request Oct 10, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants