Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse --output from --args similar to --format? #201

Closed
mre opened this issue Jul 5, 2023 · 0 comments · Fixed by #227
Closed

Parse --output from --args similar to --format? #201

mre opened this issue Jul 5, 2023 · 0 comments · Fixed by #227
Labels
design-feedback help wanted Extra attention is needed question Further information is requested

Comments

@mre
Copy link
Member

mre commented Jul 5, 2023

In #198 it was discovered that --output is ignored when used inside args. We might want to add a similar workaround as for --format:

ARGS="${INPUT_ARGS}"
FORMAT=""
# Backwards compatibility:
# If `format` occurs in args, ignore the value from `INPUT_FORMAT`
[[ "$ARGS" =~ "--format " ]] || FORMAT="--format ${INPUT_FORMAT}"

This way, users cannot run into a similar situation anymore. The alternative is to print a warning instead and show how to correctly set the output parameter.

@mre mre added help wanted Extra attention is needed question Further information is requested design-feedback labels Jul 5, 2023
mre added a commit that referenced this issue Apr 25, 2024
I decided to make this a hard error, because it keeps the entrypoint simple.

Fixes #201
@mre mre closed this as completed in #227 Apr 25, 2024
mre added a commit that referenced this issue Apr 25, 2024
I decided to make this a hard error, because it keeps the entrypoint simple.

Fixes #201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-feedback help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant