Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem setting max-redirect arg on action #164

Closed
SeanKilleen opened this issue Sep 15, 2022 · 1 comment
Closed

Problem setting max-redirect arg on action #164

SeanKilleen opened this issue Sep 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@SeanKilleen
Copy link

SeanKilleen commented Sep 15, 2022 •
edited
Loading

Maybe this is an upstream issue; let me know if it is.

Summary

Background: I'm in the process of updating GitHub's Octokit.net codebase to use newer doc links. Currently, many of their links are 301 permanently redirected.

Goal: I'd like to use the lychee-action to fail on links that are redirected.

What I tried: specifying args: --max-redirects 0 in the GitHub Action YAML for the action. (tried with quotes as well)

What I expected: Many failed links due to lots of 301 redirects.

What actually happened: Looks like the action itself failed to run, noting that I had not specified <inputs>.

Links
@mre mre mentioned this issue Oct 24, 2022
Closed
@mre mre added the enhancement New feature or request label Nov 9, 2022
mre added a commit to lycheeverse/lychee that referenced this issue Mar 10, 2023
@mre
Fix --max-redirects
065262e 
Having more than the max number of redirects
caused lychee to abort the requests, but did not
lead to an error.

lycheeverse/lychee-action#164
mre added a commit to lycheeverse/lychee that referenced this issue Mar 10, 2023
@mre
Fix --max-redirects
48b56d1 
Having more than the max number of redirects
caused lychee to abort the requests, but did not
lead to an error.

lycheeverse/lychee-action#164
@mre mre mentioned this issue Mar 10, 2023
Merged
mre added a commit to lycheeverse/lychee that referenced this issue Mar 10, 2023
@mre
Fix --max-redirects
40710d0 
Having more than the max number of redirects
caused lychee to abort the requests, but did not
lead to an error.

lycheeverse/lychee-action#164
mre added a commit to lycheeverse/lychee that referenced this issue Mar 10, 2023
@mre
Fix --max-redirects (#987)
30e2a2b 
Having more than the max number of redirects
caused lychee to abort the requests, but did not
lead to an error.

Related: lycheeverse/lychee-action#164
@mre
Copy link
Member

mre commented Mar 10, 2023

This was resolved in lycheeverse/lychee#987. In lychee@master the max-redirect flag gets properly reflected. The change will go live with the next release and will then be available in lychee-action.
Thanks for your patience.
Feel free to reopen in case it doesn't work with the next lychee-action release (>1.6.1).

@mre mre closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mre @SeanKilleen