Modernize strings #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making heavy use of the ""_L1 operator. Less clutter. Use of the QL1S macro dropped. No need for it anymore. Note: For the sake of review simplicity every string using Latin1 was converted although some can benefit from QStringLiteral improved capabilities on repeated data sharing.
Less cluttered code. Dropped QLS macro use.
QStringLiteral can now share data with the same content.
|
Ah, thanks! I did it only for libfm-qt (and will make a PR for pcmanfm-qt). I used BTW, more methods have been overloaded to accept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.