Fixed conversion to std::wstring
#554
Conversation
|
Tested by me, and especially by @correabuscar, but I prefer to wait for more tests before merging it. IMO, we'll need a point release after that. |
Fixes lxqt/qterminal#1143 and related issues.
| auto encoded = _fromUtf8(str); | ||
| std::wstring unicodeText = encoded.data.toStdWString(); | ||
| QByteArray ba(text, length); | ||
| QString str = _toUtf16(ba); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
if you wanted to be a lil more specific here...
They're exactly the same thing.
and if you wanted to be even more explicit,...
Not to this extent ;)
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I only suggested it because I saw you do this:
Yes, I guessed that :) I did so only to prevent confusion for code readers (we have a decoder now, not an encoder).
|
I could only test this under X11, but I don't see why it wouldn't work the same on Wayland |
|
I work under Wayland (LXQt+LabWC). And you're right: Wayland doesn't make a difference in this regard. |
Fixes lxqt/qterminal#1143 and related issues.