Adapt to Qt6 QProcess::setChildProcessModifier() #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't find this commit. Could you check? https://invent.kde.org/frameworks/kpty/-/commit/2117727305e8d69998154c667c284ded6b390652 says 404. |
luis-pereira
force-pushed
the
kpty-childprocess
branch
from
aaa3e63 to
314b74c
Compare
yan12125
reviewed
May 1, 2024
There was a problem hiding this comment.
Thanks for the update. Changes in kptyprocess.{cpp,h} look good. For Pty.{cpp,h}, did you reference a specific commit from https://invent.kde.org/utilities/konsole?
luis-pereira
force-pushed
the
kpty-childprocess
branch
from
314b74c to
682864e
Compare
|
@yan12125 Done. |
Qt5 QProcess::setupChildProcess() was removed. Based on KDE KPty commit d429116888921814c01a57ba4ef0144a25fd33ec It keeps sync with upstream code.
yan12125
force-pushed
the
kpty-childprocess
branch
from
682864e to
3f54fe7
Compare
|
Indentation is still off for some lines. I amended the commit and force-pushed, anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt5 QProcess::setupChildProcess() was removed.
Based on KDE KPty commit 2117727305e8d69998154c667c284ded6b390652.
It keeps sync with upstream code.