Qt6 Only #538
Closed
Qt6 Only #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update own version and CMake minimum required. Examples and Python bindings will follow.
No testing done, yet. Updating versions only, for now.
Qt5 QProcess::setupChildProcess() was removed. Based on KDE KPty commit 2117727305e8d69998154c667c284ded6b390652.
|
#532 Is in better shape. |
Yes, I merged it. I noticed changes not included in #532 are mostly in branches https://github.com/lxqt/qtermwidget/tree/versions and https://github.com/lxqt/qtermwidget/tree/kpty-childprocess now. We can work on those branches instead. |
Make PR's for those branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QProcess::setupChildProcess()toQProcess::setChildProcessModifier()When used with QTerminal wip-qt6 branch it results in a working QTerminal app.
p.s. Only when writing this I realized about #532. Didn't check it's status, yet.