Refer from konsole, prohibit to look up the historical information with the middle mouse scrolling #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some notes at the first glance:
|
…th the middle mouse scrolling. There is url can help understanding new code. https://invent.kde.org/utilities/konsole/-/commit/17c77a8729336c69bdeff970e3674d929b915b17 For function TerminalDisplay::wheelEvent, I get idea from the latest konsole code. https://invent.kde.org/utilities/konsole/-/blob/master/src/terminalDisplay/TerminalDisplay.cpp#L1662
|
Thank for ur suggestion. |
|
About #260, the PR is one kind of solution. |
yan12125
reviewed
Dec 25, 2022
| getCharacterPosition( ev->position() , charLine , charColumn ); | ||
| int charLine; | ||
| int charColumn; | ||
| getCharacterPosition( ev->pos() , charLine , charColumn ); |
There was a problem hiding this comment.
pos() is deprecated. Please change it back to position().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer from konsole, prohibit to look up the historical information with the middle mouse scrolling