Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for bookmarks examples #895

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Conversation

stefonarch
Copy link
Member

@stefonarch stefonarch commented Jan 31, 2022

Some ideas for the example file.
I see also why it was hard to use them before: file had to be created by the user first.

To do list:

  • save file at first run together with qterminal.ini
  • Rework "Find..." button: rename "Load"; open ~/.config/qterminal.org folder; limit to *.xml files
  • Message box for backwards compatibility?

@stefonarch stefonarch changed the title First draft Draft for bookmarks examples Feb 13, 2022
@yan12125 yan12125 self-requested a review February 14, 2022 06:42
@yan12125
Copy link
Member

To do list:

Will those improvements part of this PR or other future PRs? If the latter, #886 may be a better place for those notes.

Besides that, this PR looks good. The "Edit bookmarks" one is nice! Although people may not use it often, it provides a good hint.

By the way, a comment like <!-- Some examples to demonstrate how to use bookmarks. Adjust them to fit your needs. --> should make things clearer.

@yan12125 yan12125 removed their request for review February 26, 2022 14:13
@stefonarch
Copy link
Member Author

I see this as a single PR only related to the the content, #886 is more the "collection" of all ideas, there could come more even,

@yan12125
Copy link
Member

Got it! Let's move on!

@yan12125 yan12125 merged commit 65a8c78 into lxqt:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants