-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blinking cursor option to keyboard cursor submenu #698
Conversation
29fc541
to
f23a535
Compare
Thanks for this useful feature and sorry for delayed response. As there is only one new action, and it is unlikely that there will be another action in the new group, could you drop QActionGroup and just use QAction? |
f23a535
to
0ec603f
Compare
0ec603f
to
75bb1bd
Compare
Ah, somehow GitHub did not notify me for the update in March. Did you check if using By the way, it will be greater if a checkbox is added to the Appearance page of the preferences dialog. There is already a combo box for default cursor shape. |
@yan12125 Thanks for your reply. |
No problem and don't hestitate if you're unsure about anything (coding style, conventions, ...) :) |
Noticed that hanging around. Compiling I noticed that settings for presets ( "start with horizontal terminals ecc) are broken, opens only one. But maybe because it's not rebased. |
In general, I don't fix pull requests but let the authors do. If an author is unresponsive for some time, others can create a new pull request to replace the current one. |
Thanks for your comments |
Closing - reasons given earlier in this thread |
This pull request adds a new feature to qterminal:
It is now possible to choose from the keyboard cursor submenu if the cursor should be blinking or not.