Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blinking cursor option to keyboard cursor submenu #698

Closed

Conversation

UffeJakobsen
Copy link
Contributor

This pull request adds a new feature to qterminal:
It is now possible to choose from the keyboard cursor submenu if the cursor should be blinking or not.

@UffeJakobsen UffeJakobsen force-pushed the blinking_cursor_option branch from 29fc541 to f23a535 Compare July 29, 2020 21:07
@yan12125
Copy link
Member

Thanks for this useful feature and sorry for delayed response.

As there is only one new action, and it is unlikely that there will be another action in the new group, could you drop QActionGroup and just use QAction?

@UffeJakobsen UffeJakobsen force-pushed the blinking_cursor_option branch from f23a535 to 0ec603f Compare March 1, 2021 11:28
@UffeJakobsen UffeJakobsen force-pushed the blinking_cursor_option branch from 0ec603f to 75bb1bd Compare April 20, 2021 13:26
@yan12125
Copy link
Member

Ah, somehow GitHub did not notify me for the update in March.

Did you check if using QAction instead of QActionGroup works?

By the way, it will be greater if a checkbox is added to the Appearance page of the preferences dialog. There is already a combo box for default cursor shape.

@UffeJakobsen
Copy link
Contributor Author

@yan12125 Thanks for your reply.
Actually I just wanted to rebase my branch onto the latest source - so this push carries no improvement at all :-)
I'll take a look at your suggestions - thanks :-)

@yan12125
Copy link
Member

No problem and don't hestitate if you're unsure about anything (coding style, conventions, ...) :)

@stefonarch
Copy link
Member

Noticed that hanging around. Compiling I noticed that settings for presets ( "start with horizontal terminals ecc) are broken, opens only one. But maybe because it's not rebased.

@yan12125
Copy link
Member

In general, I don't fix pull requests but let the authors do. If an author is unresponsive for some time, others can create a new pull request to replace the current one.

@UffeJakobsen
Copy link
Contributor Author

Thanks for your comments
This PR is incomplete
It only adds the option to the menu - not to the preferences dialog...
It should be reworked
I think that this PR is obsolete and should be closed.

@UffeJakobsen
Copy link
Contributor Author

Closing - reasons given earlier in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants