Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with "three-em dash" #685

Closed
tsujan opened this issue Jun 4, 2020 · 1 comment · Fixed by lxqt/qtermwidget#573
Closed

Problem with "three-em dash" #685

tsujan opened this issue Jun 4, 2020 · 1 comment · Fixed by lxqt/qtermwidget#573
Labels

Comments

@tsujan
Copy link
Member

tsujan commented Jun 4, 2020

@yan12125
Feel free to close this report if it's really unimportant, especially since "three-em dash" seems to me like a suspicious character.

While I was amazed by QTerminal's high rendering quality, I found a counter-example, namely "three-em dash": ⸻

Current Behavior

The cursor position is incorrect when I type multiple "there-em dashes" with DejaVu Sans Mono. In this screenshot, the cursor should be at the line end (I just typed "haha"):

3-em-dash

Expected Behavior

The cursor position should be correct, of course.

Context

I was playing with various characters and QTerminal showed all of them correctly — until I typed multiple "there-em dashes" with DejaVu Sans Mono. Does this character contradict monospace-ness? Maybe. But the cursor position is correct with FeatherPad.

System Information
  • Latest git QTerminal
@tsujan
Copy link
Member Author

tsujan commented Dec 12, 2024

Konsole suffers from the same problem. XTerm cheats beautifully, by "compressing" this character.

Recently I fixed major cases of bad rendering; strange that this one still exists! It can't be like lxqt/qtermwidget#569; it isn't a double-column char either.

EDIT: Actually, it's a case of lxqt/qtermwidget#569 and is drawn much better than when this report was opened. A simple trick is needed for drawing it as xterm does. Will make a PR soon.

tsujan added a commit to lxqt/qtermwidget that referenced this issue Dec 12, 2024
The drawing is done like that of XTerm (actually, Qt does it), i.e., the character is "squeezed". A too wide character is defined by the code as a character whose width is twice the monospace width or more. An example is "three-em dash", which is `⸻`.

Fixes lxqt/qterminal#685
tsujan added a commit to lxqt/qtermwidget that referenced this issue Dec 12, 2024
The drawing is done like that of XTerm (actually, Qt does it), i.e., the character is "squeezed". A too wide character is defined by the code as a character whose width is twice the monospace width or more. An example is "three-em dash", which is `⸻`.

Fixes lxqt/qterminal#685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants