Main menu: implement search-on-write and improve ordering of search results #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I may not have understood well, but it's already like that (here Alt+F1 and type) |
Yes, but if you happen to hover menu items you cannot search any longer. Yea I wasn't clear enough x) |
|
Here's a small demo video illustrating the changes so far (some visual bugs can be seen): lxqt-change-demo.mp4 |
Signed-off-by: Adel KARA SLIMANE <[email protected]>
We don't need to give focus to the search line edit on hover since it will recieve the text anyway Signed-off-by: Adel KARA SLIMANE <[email protected]>
Select first result as it's the best one so far: smallest in text size and, in this order: 1. starts with the searched text 2. contains the searched text Signed-off-by: Adel KARA SLIMANE <[email protected]>
AdelKS
force-pushed
the
search-on-write
branch
2 times, most recently
from
fd9c989 to
6e51618
Compare
|
Hello, With some help I could successfully debug and rebase this PR against latest master. Feedback would be much appreciated. Thanks! |
addtionnaly filter the events of every qaction, mSearchView and mSearchEdit Signed-off-by: Adel KARA SLIMANE <[email protected]>
Signed-off-by: Adel KARA SLIMANE <[email protected]>
|
Is there anything I should do so this PR gets some attention, or maybe you find it not useful ? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR attempts to implement few features I wanted to have in the menu of LXQt panel:
That's it! Feedback welcome!
Adel