Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a race triggered by a removed wait condition in Xlib 1.7.3.1 (_XReply) #248

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

fixes a race triggered by a removed wait condition in Xlib 1.7.3.1 (_XReply) #248

wants to merge 16 commits into from

Commits on Dec 22, 2021

  1. quickfix for shitty written daemon initialization

    @antis81
    antis81 committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e832479 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2021

  1. QThread::started does not work -> shitty implementation relies on QTh… 

    …read::run
    @antis81
    antis81 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    ddcf7a5 View commit details
    Browse the repository at this point in the history

  2. debug issue lxqt#247

    @antis81
    antis81 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    0db9bf6 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. prevent calls to wakeX11Thread from within the event listener thread

    @antis81
    antis81 committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    d99caa8 View commit details
    Browse the repository at this point in the history

  2. Just output a more verbose error message and use default error handler.

    @antis81
    antis81 committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    fdb6f20 View commit details
    Browse the repository at this point in the history

  3. improve readability of current thread check

    @antis81
    antis81 committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    4a76291 View commit details
    Browse the repository at this point in the history

  4. be more verbose in logging X calls

    @antis81
    antis81 committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    33ca1fe View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. add logging around XPeekEvent

    @antis81
    antis81 committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    d356822 View commit details
    Browse the repository at this point in the history

  2. disable XFlush for testing

    @antis81
    antis81 committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    9b49b7a View commit details
    Browse the repository at this point in the history

  3. correct (de-)initialization of XEvent listener 

    - XInitThreads (and X object creation) is correctly done in main thread.
- No longer segfaults when another daemon is already running.
    @antis81
    antis81 committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    646aeca View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. use qt mutex

    @antis81
    antis81 committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    b91ad42 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. use a mutex locker on mX11ErrorMutex

    @antis81
    antis81 committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    1ecc8c6 View commit details
    Browse the repository at this point in the history

  2. set object name on QThread

    @antis81
    antis81 committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    f60f4eb View commit details
    Browse the repository at this point in the history

  3. invert mDataMutex locking logic (lock from the main thread only!) 

    Seems to work. Please test it well so we don't introduce anything harmful!
    @antis81
    antis81 committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    a19fd41 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. call XInitThreads before QApplication instance

    @antis81
    antis81 committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    21a3a03 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. remove XSynchronize call

    @antis81
    antis81 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    f2da5f2 View commit details
    Browse the repository at this point in the history