Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale monitor images on resizing monitor settings dialog #1054

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Sep 20, 2024

Also, the images are made a little larger by default.

Closes #1053

Also, the images are made a little larger by default.

Closes #1053
Copy link
Member

@stefonarch stefonarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. But we have an issue with scaled monitors, as we don't consider it. If lxqt-config-monitor is used with scaled monitors we will get a space in systemsettings which complains about "space is not supported". But this belongs to #996, and atm only KDE can configure scaling.
Schermata_20240921_102446
Schermata_20240921_102511

@tsujan
Copy link
Member Author

tsujan commented Sep 21, 2024

But we have an issue with scaled monitors

That's a completely different topic. I think the proper place for the above screenshots is #996. There they could show what we should deal with.

@tsujan
Copy link
Member Author

tsujan commented Sep 21, 2024

BTW, I'm going to add a commit for cleaning up the SVG image monitor.svg; will explain in its comment why such a cleanup is good.

@stefonarch
Copy link
Member

I just wanted to check if the monitor images itself work on scaled monitors (they do).

@tsujan
Copy link
Member Author

tsujan commented Sep 21, 2024

... (they do).

In a bad way.

`monitor.svg` contained Gaussian blur, which is not well supported by `QSvgRenderer` and can cause extra CPU usage (→ lxqt/libqtxdg#291 (comment)).
@tsujan tsujan merged commit 581d382 into master Sep 21, 2024
@tsujan tsujan deleted the monitor_image_size branch September 21, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LXQT Monitor Settings: Monitor icons are not resized on resizing dialog
2 participants