Make sure hicolor is searched before dash fallbacks
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dash fallbacks can cause all sorts of troubles. Although the inherited themes were searched *before* them, the code first ignored `hicolor` among the inherited themes and then searched it *after* dash fallbacks. That's corrected by the current patch. Fixes #260. That report is also an example of how annoying dash fallbacks could be if they aren't used *only* as the last resort.
This was referenced Jun 3, 2021
|
OK, after more than one month and because (1) it's tested by me and @stefonarch and (2) since it fixes #226 (@flychenjun also confirmed that in #255 but, for some reason unknown to me, deleted his comment when he closed that PR), I merge it and take full responsibility. If someone finds that a disaster happens with it, it could be easily reversed but that seems impossible to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dash fallbacks can cause all sorts of troubles. Although the inherited themes were searched before them, the code first ignored
hicoloramong the inherited themes and then searched it after dash fallbacks. That's corrected by the current patch.Fixes #260. That report is also an example of how annoying dash fallbacks could be if they aren't used only as the last resort.