Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit warning - path-to-regexp #15

Closed
apepper opened this issue Sep 11, 2024 · 5 comments
Closed

npm audit warning - path-to-regexp #15

apepper opened this issue Sep 11, 2024 · 5 comments

Comments

@apepper
Copy link

apepper commented Sep 11, 2024

npm audit currently gives a warning for this package due to its dependencies.

Namely the path-to-regexp package creates this warning: GHSA-9wv6-86v2-598j

It is triggered because of the following dependencies:

rewrite/package.json

Lines 34 to 35 in b3747c6

"koa-route": "^4.0.1",
"path-to-regexp": "^6.2.2"

So path-to-regexp is required directly, and indirectly via koa-route.

If possible, please upgrade the two packages in question.

@apepper
Copy link
Author

apepper commented Sep 11, 2024

Related issues: lwsjs/blacklist#2 and koajs/route#73.

@75lb
Copy link
Member

75lb commented Sep 11, 2024 via email

@75lb
Copy link
Member

75lb commented Sep 11, 2024

This will take a toucher longer to fix as upgrading path-to-regexp will break lws-rewrite and lws-blacklist due to major breaking changes in path-to-regexp recently.. I will likely drop path-to-regexp entirely and replace its previous behaviour (mainly the support for regexp input expressions, which has since been dropped) with something hand-rolled.

@75lb
Copy link
Member

75lb commented Sep 12, 2024

Made a request while I work on a new solution..

@75lb
Copy link
Member

75lb commented Sep 12, 2024

the advisory fix has been implemented in path-to-regexp v6.3.0.. This was a minor version release, meaning lws-rewrite, lws-blacklist and @koa/router will now pick up the fixed module if you reinstall.

According to koajs/router#186, you may still receive an advisory message but this should clear within a few days once the advisory database is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants