Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetbrains PHPStorm in-app notification bubbles show up in AltTab and ghost windows too #562

Closed
mfn opened this issue Aug 28, 2020 · 49 comments
Labels
bug Something isn't working unreproducible Need help from the author to reproduce the issue

Comments

@mfn
Copy link

mfn commented Aug 28, 2020

Version: 6.0.0 (but it was also happening in the one before, I just updated to confirm whether it still exists)
Describe the bug
I can trigger this with checking for updates:
image

Then this in-app notification bubble appears:
Snip20200828_12

And when I AltTab, it appears too
Snip20200828_13


It seems to me this is some buggy thing with PhpStorm in fact.

For example, I trigger the update notification bubble and don't AltTab but hover over it, I see the icons for closing:
image

Once I AltTab and see this window in use AltTab to chose the notification bubble, those hover icons don't appear anymore:
image


Sometimes I open phpstorm and open projects, I can't reproduce it immediately. Needed to close it again, open a few (3?) projects, then I could reproduce it 🤷‍♀️

@mfn mfn added the bug Something isn't working label Aug 28, 2020
@lwouis
Copy link
Owner

lwouis commented Aug 28, 2020

Hey @mfn! Thanks for sharing this issue!

This is surprising as I use JetBrains products. I'm actually developing AltTab using AppCode. I tried your "Check for updates" reproduction steps, and I can't reproduce. It works correctly:

image

I'll download PHPStorm and test there

@lwouis
Copy link
Owner

lwouis commented Aug 28, 2020

Tested on PHPStorm, and I can't reproduce. I'm on this version:

PhpStorm 2020.2.1
Build #PS-202.6948.87, built on August 27, 2020
Licensed to PhpStorm Evaluator
Expiration date: September 27, 2020
Runtime version: 11.0.8+10-b944.31 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 10.15.6
GC: ParNew, ConcurrentMarkSweep
Memory: 725M
Cores: 8
Registry: run.processes.with.pty=TRUE

@lwouis lwouis added the unreproducible Need help from the author to reproduce the issue label Aug 28, 2020
@mfn
Copy link
Author

mfn commented Aug 28, 2020

I use exactly the same version.

Yeah it's also not always reproducible, right now I can't either.

@mfn
Copy link
Author

mfn commented Aug 28, 2020

Btw, one awesome thing with the new AltTab version (I think already with 5?) is that, while it is open, I can finally use my screenshot software!

Wasn't possible before, AltTab would always close on me upon triggering the shortcuts I use (ctrl-cmd-a)

@lwouis
Copy link
Owner

lwouis commented Aug 28, 2020

Wasn't possible before, AltTab would always close on me upon triggering the shortcuts I use

A trick I use for these kind of scenarios is using the built-in Screenshot.app and put a 5s timer

@mfn
Copy link
Author

mfn commented Aug 28, 2020

Nice tip, thanks; will remember it for such cases!

I still prefer to use https://snip.qq.com/ as they provide immediately the ability to draw on the canvas which I do 99% of the time 😆

@mfn
Copy link
Author

mfn commented Sep 1, 2020

In the meantime I'm on 6.1.0 and I can't reproduce it either (but it also didn't appear anymore also with the previous version) => closing!

@mfn mfn closed this as completed Sep 1, 2020
@mfn
Copy link
Author

mfn commented Sep 7, 2020

Happened again right now with 6.2.0

image

@lwouis
Copy link
Owner

lwouis commented Sep 7, 2020

Did it happen after your started AltTab? Like PHPStorm was already running and you started AltTab after?

@mfn
Copy link
Author

mfn commented Sep 7, 2020

Like PHPStorm was already running and you started AltTab after?

No, it was running for a long time already, basically since #563 (comment)

In the meantime I moved to the other version though from #563 (comment)

@lwouis
Copy link
Owner

lwouis commented Sep 8, 2020

What about the 2 windows on the left of the notification window? Were they there from the beginning? Did they appear over time, did they appear exactly when the notification window appeared?

How often does this issue happen overall? Like if you close AltTab or PHPStorm now and re-open, is it going to be working fine for a while until it happens again, or is it doing it straight away?

I tried all sorts of things but can't reproduce locally.

@lwouis lwouis reopened this Sep 8, 2020
@mfn
Copy link
Author

mfn commented Sep 8, 2020

Were they there from the beginning? Did they appear over time, did they appear exactly when the notification window appeared?

Yes, they exactly appeared together at the same time!

How often does this issue happen overall? Like if you close AltTab or PHPStorm now and re-open, is it going to be working fine for a while until it happens again, or is it doing it straight away?

It happened this once after a while, because first time after this ticket was closed.

Maybe this is a red herring thing because I temporarily used 5.3.x for the other issue. I.e. maybe I went back to the version which has this problem but maybe 6.x doesn't have it (as I said, haven't seen it since we closed the ticket which AFAIR was before 6.x was out).

I haven't seen it since 6.x but that's not a long time.

I tried some combination with closing AltTab and producing the popup notification in PS and then starting AltTab and the other way around, but not really reproducible.

Maybe I really saw this because I was on 5.x for testing the other issue after all 🤔

@lwouis
Copy link
Owner

lwouis commented Sep 8, 2020

Let's keep this ticket open, and please report here if it happens again on the latest versions. Also when it does, please try to remember the chronology of action: when did you start AltTab, when did you start PHPStorm, when did you notice the issue in AltTab.

Also how does it react if you quit PHPStorm, etc

@mfn
Copy link
Author

mfn commented Oct 27, 2020

Happened to me again today; very rarely this comes up:
image

This is with 6.7.4, but after that upgraded to 6.8.0

@mfn
Copy link
Author

mfn commented Oct 27, 2020

Seems the DataGrip EAP also has this. I'm not using it as much as PhpStorm, so I didn't notice it until right now:
image

I do not have that many DataGrip windows open, only two in fact. Stopping/Starting AltTab fixed this, as it was quite persistent and I could not close those "ghost windows" via AltTab (and there existing none otherwise)

This is with the latest AltTab 6.8.0

@lwouis
Copy link
Owner

lwouis commented Oct 27, 2020

The small blue rectangles seem to be either text selection or some suggestion? It seems IntelliJ uses window objects for a host of things. It's a cross-platform Java app after all, so it shouldn't be surprising that it doesn't integrate well in macOS. I'm just surprised it never does this behavior on my machine. Maybe you use a certain feature that I don't, or maybe it's a plugin that's causing these.

I keep thinking these days that I should just add size check for the windows, as discussed in #456. It would probably remove all these false-positives at reasonable performance cost.

@lwouis
Copy link
Owner

lwouis commented Oct 27, 2020

@mfn here is a local build I made which filters out windows with no size, or a width/height < 100px. Could you try it out and let me know how it works for you? It will be helpful to not only test the Jetbrains EAP apps, but also regular apps to see that there is no regressions. It could filter out actual small windows. I can't imagine a legitimate window that users would want to see in AltTab that would be smaller than this though, but I may be wrong who knows.

@mfn
Copy link
Author

mfn commented Oct 27, 2020

@lwouis thank you, I just started it and was pretty quickly able to reproduce it:
image

Double checked it's not a "released" version:
image

Now that I think of it, that's definitely a DataGrip EAP thing, I had nothing like that every before. Not in that amount and so easily happening.

@lwouis
Copy link
Owner

lwouis commented Oct 27, 2020

How can these windows show when I added the size check? They must be bigger than 100x100 but have transparent regions 🙉

I'll try installing DataGrip to see if I can reproduce. You're making me install the whole Jetbrains suite ;p

@mfn
Copy link
Author

mfn commented Oct 27, 2020

You're making me install the whole Jetbrains suite ;p

I am so sorry for that 😱

Well, it's a good suite. The DataGrip EAP is at https://www.jetbrains.com/datagrip/nextversion/

However I do have db connections set up, query them, copy paste columns content (e.g. json), create temporary window to reformat it => so they kind of actions might relate to what kind of "windows" are created…

@lwouis
Copy link
Owner

lwouis commented Oct 27, 2020

You mean these are not present after a start? They only appear after you use the app a bunch?

If you could find which steps specifically trigger this, that would be ideal

@lwouis
Copy link
Owner

lwouis commented Oct 27, 2020

Omg yes! I could get one glitchy window finally! I set up a connection, and did come copy pastes. I think it's having a tooltip show up on hovering the table that did it though. Update: yes, the tooltip do it for sure, when text doesn't fit in a cell and you hover. I can hover while AltTab is open, and see these pop in and out in AltTab

I'll finally be able to see these windows characteristics!

@lwouis
Copy link
Owner

lwouis commented Oct 27, 2020

Oh wow! There was a logic bug in a long boolean expression [1], and after spending 10min looking at it I realized why it was not filtering these windows. I'm surprised not more apps were impacted by the logic bug.

I'm going to push a public release with this change. Could you please tell me if this build fixes it for you? It fixes it for me

[1]
image

@mparry
Copy link

mparry commented Oct 29, 2020

Screenshot 2020-10-29 at 10 53 09

@lwouis
Copy link
Owner

lwouis commented Oct 29, 2020

Do you have consistent steps to reproduce? I need to get it locally to understand why the window is not filtered by it's size since it looks to be 0x0

@lwouis lwouis reopened this Oct 29, 2020
@mparry
Copy link

mparry commented Oct 29, 2020

Sorry, no. Indeed, it hasn't occurred at all today. I did pick up a Rider EAP update this morning, so it's possible they've altered something. Unless anyone else is still seeing anything, I'm personally quite happy for you to leave this issue closed, until more concrete details are available. As I said above, it was rather annoying before because there might be 10+ spurious windows in AltTab, but I haven't seen more than 1 since your last change (and 0 today).

@mparry
Copy link

mparry commented Nov 2, 2020

I still don't have a repro but here's a somewhat more informative screenshot:

Screenshot 2020-11-02 at 16 39 59 (2)

As you can see, it's a tooltip. However, this certainly doesn't happen every time a tooltip is shown.

@lwouis
Copy link
Owner

lwouis commented Nov 3, 2020

Tooltips are not showing for me in CLion (public release, not EAP). That's the IDE I use to develop AltTab, so I think I would have run into the issues by now. This makes me think it's EAP specific, which is also what I observed above with PHPStorm or DataGrip.

It would be nice to get Jetbrains perspective on this issue by reporting it to them. They may shed some light on what they changed in the EAP channel that could create this issue.

@Alexsey
Copy link

Alexsey commented Nov 3, 2020

I can confirm the bug is still there and relevant for the WebStorm as well. Althought, after the last fix, it become much harder to reproduce - I can work for half a day and not seen any empty items

@mparry
Copy link

mparry commented Nov 3, 2020

One way that I can make it happen slightly more reliably - maybe 50% of the time? - is to invoke AltTab while I am actually hovering over code so that a tooltip displays - the tooltip is often then present in the window list. Most of the time, it will disappear if I stop hovering (rather than leaving something permanently in the list, as I see less often) but perhaps this would at least help figure out why it's getting past your filtering.

@Alexsey
Copy link

Alexsey commented Nov 3, 2020

Yes, I agree with @mparry - it's relatively easy to get the tooltip to alttab with the proposed way (about 20-40% in my case). But tooltips in alttab are not persistent - they will disappear after the tooltip close. But sometimes there can be empty socets that would persist untill IDE restart, like in the initial issue - and that one are much harder to reproduce :( Will keep an eye on what can couse them

@lwouis
Copy link
Owner

lwouis commented Nov 3, 2020

relevant for the WebStorm as well

Are you using WebStorm EAP or stable release?

@Alexsey
Copy link

Alexsey commented Nov 3, 2020

EAP. All this problem started in EAP - the previous stable didn't had this issues

@mfn
Copy link
Author

mfn commented Nov 13, 2020

Had this happen today again to me with latest AltTab and EAP:
image

Just for documentation. But it really happens rarely.

The notification window in question was already long gone at the point I saw it here. Neither focusing not closing it via AltTab was possible.

I even closed all PhpStorm windows so that only the "project chooser" / welcome screen would appear and they would still be displayed via AltTab.

Only when I completely closed PhpStorm, they were gone.

I forgot to test what would have happened if I would have restarted AltTab.

@lwouis
Copy link
Owner

lwouis commented Nov 13, 2020

Do you see these windows normally in AltTab? I mean in addition to the fact that they remain after they are closed. It seems from the visuals that these shouldn't appear ever. The issue would be 2 sided: how can this show up in the first place, and how come once it's shown it stays there even when it's closed.

@mfn
Copy link
Author

mfn commented Nov 14, 2020

Do you see these windows normally in AltTab? I

No, not at all!

And I absolutely agree with this:

how can this show up in the first place

I think they shouldn't show up in the first place.

and how come once it's shown it stays there even when it's closed.

To be clear, I wrote:

I even closed all PhpStorm windows so that only the "project chooser" / welcome screen would appear and they would still be displayed via AltTab.

What I mean with this is, the "process" of PhpStorm was still present all along. It's just within the various open project windows have been closed.

Granted, I know nothing technically about all this but I can imagine that unless the process disappears, there are still some dangling references. So that even if I close the "main window" of a project, the overall java process is still there (and AFAIK PhpStorm & friends run in a VM which only shuts down if you truly completely quit PhpStorm, not just when I close a project window).

@mfn
Copy link
Author

mfn commented Nov 16, 2020

I've one such window currently. It's a pretty big one (a "notification bubble" for a git commit message with it's content can be quite big on the screen), but again usually this doesn't happen:
image

I forgot to test what would have happened if I would have restarted AltTab.

I now did test this and after stopping/starting AltTab, this window disappeared ❗ too.

@lwouis
Copy link
Owner

lwouis commented Jan 25, 2021

I just released v6.13.0 which should fix the issue on all Jetbrains apps 👍 Please let me know if you still face issues on that version

@FirstTimeInForever
Copy link

Seen this issue with current IDEA EAP (2021.1-EAP).
For the context: IDEA was performing indexing and importing gradle project.
AltTab version 6.15.0
image

@lwouis
Copy link
Owner

lwouis commented Feb 11, 2021

I think it would be nice to open tickets in Jetbrains support system, in addition to workaround their bugs on AltTab's side. Issues where AltTab displays wrong windows are always because app authors use NSWindow for things that are not windows. Jetbrains uses Swing I believe, so they do their UI through abstractions that map poorly to AppKit on macOS. This is the root cause. They should address it. In addition to us working around the issue in the meanwhile.

@lwouis
Copy link
Owner

lwouis commented Feb 26, 2021

I witnessed this today. Very interesting:

image

image

image

You can see on the last screenshot that Mission Control is showing the 2 IntelliJ notifications. Even to the OS, these are independent windows, and not light HUDs. AltTab is here doing "better" than the OS, showing that the issue is with IntelliJ to begin with.

Update: as soon as I posted this, the behavior changed:

Screen.Recording.2021-02-26.at.15.53.48.mov

Previous behavior:

Screen.Recording.2021-02-26.at.16.00.03.mov

This shows that the issue from IntelliJ is not stable over time.

@lwouis
Copy link
Owner

lwouis commented Apr 20, 2021

I witnessed another tooltip showing in AltTab today. Here are the logs for it:

Optional("com.jetbrains.AppCode") Optional("") 0 Optional("AXDialog") Optional("AXWindow") Optional((333.0, 110.0))
  • It has an empty title, but some legitimate windows don't have a title either, so we can filter based on that.
  • It's a AXDialog, but popups should be shown in AltTab, so we can filter based on that.
  • It has a width and a height bigger than the 100px limit we set in AltTab, so we can filter based on that.

Currently I don't think there is any way we could prevent such popups showing in AltTab. It's really Jetbrains who ought to not implement their tooltips using AXDialog NSWindow.

@AfzalivE
Copy link
Contributor

Anyone also finding that when AltTab is running, some of the popups just don't disappear? Not sure if it's happening in PHPStorm as well but it's definitely happening on the beta/canary versions of Android Studio.

@lwouis
Copy link
Owner

lwouis commented Jul 28, 2021

@AfzalivE if it's only happening on the beta/canary, then it's clearly a regression. I suggest you open a ticket with Jetbrains to get someone from their team to look into the issue

Potentially related: #1056 (comment)

@twyatt
Copy link

twyatt commented Jul 31, 2021

Related Android Studio bug: https://issuetracker.google.com/issues/189250915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unreproducible Need help from the author to reproduce the issue
Projects
None yet
Development

No branches or pull requests

7 participants