Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow navigation with up/down arrow keys #270

Closed
gitgetgot opened this issue Apr 23, 2020 · 2 comments
Closed

Allow navigation with up/down arrow keys #270

gitgetgot opened this issue Apr 23, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@gitgetgot
Copy link

Bildschirmfoto 2020-04-23 um 21 05 43

If activated, only use of left/right arrows seems to be possible, but with two or more rows it would be nice to press up/down to quickly access the desired tab.

@lwouis
Copy link
Owner

lwouis commented Apr 23, 2020

There is already a ticket for that: #64. It's not trivial to implement, thus while it's been in the backlog for a little while now, unfortunately. I'll close the other one as duplicate as yours has screenshot and the other ticket talks about the old collectionview which is no longer how it's implemented.

@lwouis lwouis added the enhancement New feature or request label Apr 23, 2020
@lwouis lwouis changed the title Only left/right arrows are working to chose tabs. up/down would be nice too Allow navigation with up/down arrow keys Apr 23, 2020
@lwouis
Copy link
Owner

lwouis commented Apr 27, 2020

While implementing this, I first started with a geometrical-based approach: going down means finding the next thumbnail in that direction, potentially skipping multiple rows. For example going from 1 to 2, by pressing down:

[   ]  [   ]  [ 1 ]
       [   ] 
[   ]  [   ]  [ 2 ]

Then I tested on Windows 10, and they do row-by-row which I think is more suited for what our use-case of switching windows. The same example would do this here:

[   ]  [   ]  [ 1 ]
       [ 2 ] 
[   ]  [   ]  [   ]

@lwouis lwouis closed this as completed in cc61ed4 Apr 27, 2020
lwouis pushed a commit that referenced this issue Apr 27, 2020
# [3.17.0](v3.16.3...v3.17.0) (2020-04-27)

### Bug Fixes

* shift key + scroll should scroll the ui ([d64a6a5](d64a6a5))
* update russian localization ([942c4d7](942c4d7))

### Features

* navigate with up/down arrow keys (closes [#270](#270)) ([cc61ed4](cc61ed4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants