Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for priorityClass and containerSecurityContext #83 #84

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

AshutoshNirkhe
Copy link
Contributor

No description provided.

@AshutoshNirkhe
Copy link
Contributor Author

@lwolf any plan on releasing next version of chart so that I can use these settings ?

@lwolf
Copy link
Owner

lwolf commented Mar 16, 2022

yes, will make a release over weekend

@AshutoshNirkhe
Copy link
Contributor Author

yes, will make a release over weekend

Sorry but any luck with new release @lwolf ?

@lwolf
Copy link
Owner

lwolf commented Mar 21, 2022

not really, apparently travis-ci ceased to exist, so I need to do a migration to github-actions.
You can use chart directly from this repo if you "have to". I'll try to bump it manually in "lwolf-charts" without CI

@AshutoshNirkhe
Copy link
Contributor Author

not really, apparently travis-ci ceased to exist, so I need to do a migration to github-actions. You can use chart directly from this repo if you "have to". I'll try to bump it manually in "lwolf-charts" without CI

I see. We are using terraform automation around that and currently fetching the chart from this upstream repo. Really appreciate if you could bump it without CI :)

@lwolf
Copy link
Owner

lwolf commented Mar 22, 2022

@AshutoshNirkhe do you fetch it from this repo (by getting tar.gz of the repo and then installing the chart) or do you use hosted charts - https://github.com/lwolf/kube-charts ?

@AshutoshNirkhe
Copy link
Contributor Author

@AshutoshNirkhe do you fetch it from this repo (by getting tar.gz of the repo and then installing the chart) or do you use hosted charts - https://github.com/lwolf/kube-charts ?

I am using helm_release terraform resource which in the end uses https://charts.lwolf.org to fetch the kube-cleanup chart.

@lwolf
Copy link
Owner

lwolf commented Mar 22, 2022

pushed the new version of the chart. Could you try it?

@AshutoshNirkhe
Copy link
Contributor Author

pushed the new version of the chart. Could you try it?

Will try it out and let you know more, thanks a lot.

@AshutoshNirkhe
Copy link
Contributor Author

AshutoshNirkhe commented Mar 27, 2022

pushed the new version of the chart. Could you try it?

@lwolf sorry to bother again, but I messed up the indentation in this PR. So opened #86 to fix just that. Off course one line change. Could you please review/merge that and re-build/push chart version 1.0.2 or create 1.0.3 ?

@lwolf
Copy link
Owner

lwolf commented Mar 28, 2022

pushed, try kube-cleanup-operator-1.0.4

@AshutoshNirkhe
Copy link
Contributor Author

pushed, try kube-cleanup-operator-1.0.4

thanks a bunch @lwolf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants