Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Drop support for Rails 6.0 #168

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[TASK] Drop support for Rails 6.0 #168

merged 1 commit into from
Oct 6, 2023

Conversation

joshRpowell
Copy link
Contributor

@joshRpowell joshRpowell commented Oct 5, 2023 •
edited
Loading

oliverklee
oliverklee requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code/configuration changes look very good! Thank you!

The changelog needs some more love, though.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
oliverklee
oliverklee approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! ❤️

@oliverklee oliverklee merged commit 463c90b into lwe:main Oct 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@joshRpowell joshRpowell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshRpowell @oliverklee