[BUGFIX] Avoid modifying a frozen array in Ruby 3 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
bugfix/frozen-strings
branch
7 times, most recently
from
13d9353 to
cda1c37
Compare
oliverklee
force-pushed
the
bugfix/frozen-strings
branch
from
cda1c37 to
a79d7fa
Compare
|
@lwe Gentle ping for a review as this PR will get the build back to green again, and I really would like to have a second pair of eyes on these changes. |
oliverklee
force-pushed
the
bugfix/frozen-strings
branch
2 times, most recently
from
cc0fa46 to
810edea
Compare
Also make the code more readable. Fixes #132
oliverklee
force-pushed
the
bugfix/frozen-strings
branch
from
810edea to
26965e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the code more readable.
Fixes #132