Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use e- to avoid conflict with bootstrap #9

Closed
wants to merge 1 commit into from
Closed

Conversation

xdite
Copy link

@xdite xdite commented Dec 19, 2013

No description provided.

@lwe
Copy link
Owner

lwe commented Dec 19, 2013

Thanks, but this is likely going to break entypo-rails for all existing users, however I do have an idea that we could use and .erb extension and add a configuration option to change the prefix to whatever the user likes, what do you think?

lwe added a commit that referenced this pull request Dec 19, 2013
To avoid conflicts with other stylesheets that define `.icon-` classes
and basically bootstrap and option was introduced to customize this
prefix.

/cc @xdite #9
@lwe
Copy link
Owner

lwe commented Dec 19, 2013

FYI, I've released 2.2.1 with the css_prefix option, to use simply add an initializer that contains

# config/initializers/entypo.rb
Entypo.css_prefix = "e-icon"

then ensure to clean tmp/cache/assets and restart your server.

Hope this helps, I'm thus closing this ticket in favor of the new css_prefix option.

@lwe lwe closed this Dec 19, 2013
@lwe
Copy link
Owner

lwe commented Dec 19, 2013

Thanks for your contribution anyhow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants