added box detached api #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
+ Coverage 96.46% 96.66% +0.2%
=========================================
Files 14 14
Lines 509 540 +31
Branches 2 2
=========================================
+ Hits 491 522 +31
Misses 16 16
Partials 2 2
Continue to review full report at Codecov.
|
lvh
reviewed
Jun 14, 2018
src/caesium/crypto/box.clj
Outdated
| (bb/->indirect-byte-buf nonce) | ||
| (bb/->indirect-byte-buf pk) | ||
| (bb/->indirect-byte-buf sk)) | ||
| {:ctext (bb/->bytes c) |
There was a problem hiding this comment.
this should probably use the same name as the upstream api: :c
|
this looks great except for the name nit; thanks! |
|
Done! Thank you. I am learning a lot |
|
Neat, thanks! I should really cut a release for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey again @lvh !
This fixes issue #5
Let me know what you think.