ensure getEnvOption('pageObject'') resolves the PageObject

[nadar]

#401 (comment)

[nadar]

@hbugdoll now it resolves the NavItemPage object, which is the expected as the context key is known as pageObject and not navItemObject. Feel free to review. I have also ajdust the docs for the upcoming changes => https://luya.io/guide/cms/blocks.html#env-context-information

[nadar]

@hbugdoll i'am going to merge, need to tag a fresh release. if there is anything left, please create a PR. thank you very much for all the hints and help.

[hbugdoll]

@hbugdoll i'am going to merge, need to tag a fresh release. if there is anything left, please create a PR. thank you very much for all the hints and help.

I'm a little bit to late, my review is just finished. It's all ok.
Thank you for your patience.

[hbugdoll]

I have also ajdust the docs for the upcoming changes => https://luya.io/guide/cms/blocks.html#env-context-information

pageObject: Returns the luya\cms\models\NavItemPage object where you can run luya\cms\models\NavItemPage -> getNavItem() to retrieve the luya\cms\models\NavItem object, from there its possible to run luya\cms\models\NavItem -> getNav() to retrieve the luya\cms\models\Nav

We only have to adjust the docs again...
As I have learned now, getNavItem() and getNav() returns not the NavItem resp. Nav objects.

[nadar]

thats the relation loading concept uf yii2, i assume people are familiar with those concepts. We have to point to the relations getXYZ() method, as they exists in the docs: https://api.luya.io/luya-cms-models-navitempage.html#getNavItem()-detail

Or did i understand you wrong?

[nadar]

@hbugdoll but please feel free to extend and improve the docs, its always welcome 👍

[hbugdoll]

In my opinion it is misleading because you have to call $this->getEnvOption('pageObject')->navItem->nav
instead of $this->getEnvOption('pageObject')->getNavItem()->getNav().

[nadar]

Sure, you can extend this. For me it was important to point into the api docs and i assume people understand the relation concept uf yii2. but please add some more extra text if you like 👍